From: Greg KH <greg@kroah.com>
To: Luben Tuikov <ltuikov@yahoo.com>
Cc: linux-usb@vger.kernel.org, linux-scsi@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH take 2] [USB] Use normalized sense when emulating autosense
Date: Thu, 11 Nov 2010 05:44:50 -0800 [thread overview]
Message-ID: <20101111134450.GB12291@kroah.com> (raw)
In-Reply-To: <985163.58416.qm@web31807.mail.mud.yahoo.com>
On Fri, Oct 22, 2010 at 02:12:51PM -0700, Luben Tuikov wrote:
> This patch solves two things:
> 1) Enables autosense emulation code to correctly
> interpret descriptor format sense data, and
> 2) Fixes a bug whereby the autosense emulation
> code would overwrite descriptor format sense data
> with SENSE KEY HARDWARE ERROR in fixed format, to
> incorrectly look like this:
>
> Oct 21 14:11:07 localhost kernel: sd 7:0:0:0: [sdc] Sense Key : Recovered Error [current] [descriptor]
> Oct 21 14:11:07 localhost kernel: Descriptor sense data with sense descriptors (in hex):
> Oct 21 14:11:07 localhost kernel: 72 01 04 1d 00 00 00 0e 09 0c 00 00 00 00 00 00
> Oct 21 14:11:07 localhost kernel: 00 4f 00 c2 00 50
> Oct 21 14:11:07 localhost kernel: sd 7:0:0:0: [sdc] ASC=0x4 ASCQ=0x1d
>
> Signed-off-by: Luben Tuikov <ltuikov@yahoo.com>
I need to get the ack from the usb-storage maintainer. Can you get that
so that I can apply this?
thanks,
greg k-h
next prev parent reply other threads:[~2010-11-11 13:44 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-22 21:12 [PATCH take 2] [USB] Use normalized sense when emulating autosense Luben Tuikov
2010-11-11 13:44 ` Greg KH [this message]
2010-11-11 16:49 ` Luben Tuikov
2010-11-11 16:57 ` Greg KH
[not found] ` <20101111165717.GA8526-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2010-11-11 17:07 ` Luben Tuikov
2010-11-11 17:43 ` Matthew Dharm
2010-11-11 18:27 ` Luben Tuikov
[not found] ` <673670.8195.qm-n6NU40r8ZaqvuULXzWHTWIglqE1Y4D90QQ4Iyu8u01E@public.gmane.org>
2010-11-11 18:49 ` Matthew Dharm
2010-11-11 19:11 ` Greg KH
[not found] ` <20101111191110.GA12308-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2010-11-11 19:50 ` Luben Tuikov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101111134450.GB12291@kroah.com \
--to=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=ltuikov@yahoo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox