Re: [PATCH take 2] [USB] Use normalized sense when emulating autosense

Luben Tuikov
2010-11-11T18:27:13Z

--- On Thu, 11/11/10, Matthew Dharm <mdharm-kernel@one-eyed-alien.net> wrote:
> On Thu, Nov 11, 2010 at 09:07:53AM -0800, Luben Tuikov wrote:
> >
> > Oh, I see. I'll re-post the patch then to Matthew and
> the people and lists you listed above.
>
> Now that I'm on the CC, I see this.
>
> What's the 10k-foot level summary here?

I'm not sure either. It's apparently the procedure of getting a patch into the linux kernel nowadays. Last time I did this was 5 years ago and in linux-scsi--I remember it being easier, again that was 5 years ago.

> Is there an alternate sense-data format that uses some sort of "descriptor" structure?

Yes. Some devices return this format of sense data for some commands.

> I'm assuming this is
> a new SCSI-III thing, or did I just miss it in SCSI-II?
> This *looks* like you're using functions provided by the
> SCSI core to
> access and modify the sense data... so I'm assuming that's
> because there
> are alternate formats...

The patch doesn't add code that modifies the sense data. That modification code is already there, the patch fixes the modification which assumed only one type of format of sense data.

The patch uses SCSI functions to abstract the sense information irrespective of the type of format of sense data.

>
> Matt
>
> --
> Matthew Dharm
>
>   Home: mdharm-usb@one-eyed-alien.net
>
> Maintainer, Linux USB Mass Storage Driver
>
> It was a new hope.
>
>         -- Dust Puppy
> User Friendly, 12/25/1998
>
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html