From: Matthew Wilcox <matthew@wil.cx>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: James Bottomley <James.Bottomley@suse.de>,
"Nicholas A. Bellinger" <nab@linux-iscsi.org>,
Jeff Garzik <jeff@garzik.org>,
Andrew Morton <akpm@linux-foundation.org>,
linux-scsi <linux-scsi@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [GIT PULL] SCSI queuecommand API change for 2.6.37-rc1
Date: Fri, 12 Nov 2010 21:28:22 -0700 [thread overview]
Message-ID: <20101113042821.GE18258@parisc-linux.org> (raw)
In-Reply-To: <AANLkTinj2BM2eGo2yyfzs=t+nu79WLW_bGYota9sDZwH@mail.gmail.com>
On Fri, Nov 12, 2010 at 05:42:06PM -0800, Linus Torvalds wrote:
> And the sad thing is that this could _trivially_ have been fixed while
> actually making the patch no bigger. Make the new function look like
>
> int func(struct Scsi_Host *shost, struct scsi_cmnd *cmd, void
> (*done)(struct scsi_cmnd *));
Actually, it'd be even better if we took away an argument.
int queuecommand(struct scsi_cmnd *cmd);
Every single driver sets cmd->scsi_done = done;
(some don't do it immediately, but they all do it eventually. Do it in
the single caller, and eventually remove the assignments from the drivers).
--
Matthew Wilcox Intel Open Source Technology Centre
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours. We can't possibly take such
a retrograde step."
next prev parent reply other threads:[~2010-11-13 4:28 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-12 23:55 [GIT PULL] SCSI queuecommand API change for 2.6.37-rc1 James Bottomley
2010-11-13 0:38 ` Nicholas A. Bellinger
2010-11-13 1:42 ` Linus Torvalds
2010-11-13 2:03 ` Jeff Garzik
2010-11-13 2:09 ` Jeff Garzik
2010-11-13 2:30 ` Linus Torvalds
2010-11-13 4:28 ` Matthew Wilcox [this message]
2010-11-13 4:42 ` Linus Torvalds
2010-11-13 5:26 ` Jeff Garzik
2010-11-13 6:01 ` James Bottomley
2010-11-13 6:07 ` Jeff Garzik
2010-11-13 7:18 ` Nicholas A. Bellinger
2010-11-16 6:57 ` Jeff Garzik
2010-11-16 7:08 ` Jeff Garzik
2010-11-13 5:16 ` [PATCH v4] SCSI host lock push-down Jeff Garzik
2010-11-13 6:01 ` Jeff Garzik
2010-11-16 7:10 ` [PATCH v5] " Jeff Garzik
2010-11-16 7:31 ` Jeff Garzik
2010-11-16 17:25 ` Linus Torvalds
2010-11-16 17:36 ` James Bottomley
2010-11-16 21:30 ` Linus Torvalds
2010-11-16 21:32 ` James Bottomley
2010-11-16 21:26 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101113042821.GE18258@parisc-linux.org \
--to=matthew@wil.cx \
--cc=James.Bottomley@suse.de \
--cc=akpm@linux-foundation.org \
--cc=jeff@garzik.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=nab@linux-iscsi.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox