From: Christoph Hellwig <hch@infradead.org>
To: "Nicholas A. Bellinger" <nab@linux-iscsi.org>
Cc: linux-scsi <linux-scsi@vger.kernel.org>,
Jeff Garzik <jeff@garzik.org>,
James Bottomley <James.Bottomley@suse.de>,
Christoph Hellwig <hch@lst.de>,
Mike Christie <michaelc@cs.wisc.edu>,
Ravi Anand <ravi.anand@qlogic.com>,
Andrew Vasquez <andrew.vasquez@qlogic.com>,
Joe Eykholt <jeykholt@cisco.com>,
James Smart <james.smart@emulex.com>,
Vasu Dev <vasu.dev@linux.intel.com>,
Tim Chen <tim.c.chen@linux.intel.com>,
Andi Kleen <ak@linux.intel.com>, Tejun Heo <tj@kernel.org>,
Mike Anderson <andmike@linux.vnet.ibm.com>,
MPTFusionLinux <DL-MPTFusionLinux@lsi.com>
Subject: Re: [PATCH 04/11] libsas: Convert to host_lock less w/ interrupts disabled externally
Date: Wed, 17 Nov 2010 17:30:53 -0500 [thread overview]
Message-ID: <20101117223053.GB26760@infradead.org> (raw)
In-Reply-To: <1290032331-4919-1-git-send-email-nab@linux-iscsi.org>
> @@ -189,7 +189,7 @@ int sas_queue_up(struct sas_task *task)
> * Note: XXX: Remove the host unlock/lock pair when SCSI Core can
> * call us without holding an IRQ spinlock...
That comment can be removed now.
> */
> -static int sas_queuecommand_lck(struct scsi_cmnd *cmd,
That's now how the code looks like upstream.
> +static int sas_queuecommand_irq_disable(struct scsi_cmnd *cmd,
> void (*scsi_done)(struct scsi_cmnd *))
> __releases(host->host_lock)
> __acquires(dev->sata_dev.ap->lock)
The host_lock annotations are not incorrect, and the sata_dev ones
never made sense.
> @@ -254,7 +254,7 @@ out:
> return res;
> }
>
> -DEF_SCSI_QCMD(sas_queuecommand)
> +IRQ_DISABLE_SCSI_QCMD(sas_queuecommand)
And in addition this doesn't even seem correct to me. First thing
sas_queuecommand upstream does is spin_unlock_irq on the host_lock
which it expects to be held, then it does a spin_lock_irqsave for the
sata case, or operations that do not appear to need a lock for the
sas case.
next prev parent reply other threads:[~2010-11-17 22:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-17 22:18 [PATCH 04/11] libsas: Convert to host_lock less w/ interrupts disabled externally Nicholas A. Bellinger
2010-11-17 22:30 ` Christoph Hellwig [this message]
2010-11-17 22:36 ` Nicholas A. Bellinger
-- strict thread matches above, loose matches on Subject: below --
2010-11-12 0:13 Nicholas A. Bellinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101117223053.GB26760@infradead.org \
--to=hch@infradead.org \
--cc=DL-MPTFusionLinux@lsi.com \
--cc=James.Bottomley@suse.de \
--cc=ak@linux.intel.com \
--cc=andmike@linux.vnet.ibm.com \
--cc=andrew.vasquez@qlogic.com \
--cc=hch@lst.de \
--cc=james.smart@emulex.com \
--cc=jeff@garzik.org \
--cc=jeykholt@cisco.com \
--cc=linux-scsi@vger.kernel.org \
--cc=michaelc@cs.wisc.edu \
--cc=nab@linux-iscsi.org \
--cc=ravi.anand@qlogic.com \
--cc=tim.c.chen@linux.intel.com \
--cc=tj@kernel.org \
--cc=vasu.dev@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox