From: Russell King <rmk@arm.linux.org.uk>
To: Jesper Juhl <jj@chaosbits.net>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
linux-scsi@vger.kernel.org,
"James E.J. Bottomley" <James.Bottomley@suse.de>,
linux-kernel@vger.kernel.org, Eric Youngdale <eric@andante.org>,
"David S. Miller" <davem@davemloft.net>,
Mike Anderson <andmike@us.ibm.com>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH][resend][SCSI] Reduce number of sequential pointer derefs in scsi_error.c and reduce size as well
Date: Thu, 18 Nov 2010 21:06:42 +0000 [thread overview]
Message-ID: <20101118210642.GA24236@flint.arm.linux.org.uk> (raw)
In-Reply-To: <alpine.LNX.2.00.1011182140510.8526@swampdragon.chaosbits.net>
On Thu, Nov 18, 2010 at 09:49:29PM +0100, Jesper Juhl wrote:
> @@ -617,10 +623,10 @@ static int scsi_try_bus_device_reset(struct scsi_cmnd *scmd)
>
> static int __scsi_try_to_abort_cmd(struct scsi_cmnd *scmd)
> {
> - if (!scmd->device->host->hostt->eh_abort_handler)
> - return FAILED;
> -
> - return scmd->device->host->hostt->eh_abort_handler(scmd);
> + struct scsi_host_template *hostt = scmd->device->host->hostt;
> + if (!hostt->eh_abort_handler)
> + return FAILED;
> + return hostt->eh_abort_handler(scmd);
Not that I have much to do with SCSI anymore... I spotted the above.
Is there any particular reason for using spaces to indent here rather
than our usual tabs?
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of:
next prev parent reply other threads:[~2010-11-18 21:07 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-18 19:30 [PATCH][resend][SCSI] Reduce number of sequential pointer derefs in scsi_error.c and reduce size as well Jesper Juhl
2010-11-18 20:41 ` Linus Torvalds
2010-11-18 20:49 ` Jesper Juhl
2010-11-18 20:57 ` Jesper Juhl
2010-11-18 21:06 ` Russell King [this message]
2010-11-18 20:59 ` Jesper Juhl
2010-11-18 21:18 ` Linus Torvalds
2010-11-18 21:21 ` Jesper Juhl
2010-11-20 20:30 ` Jesper Juhl
2010-11-21 0:03 ` Linus Torvalds
2010-11-21 18:48 ` Jesper Juhl
2010-12-21 17:37 ` James Bottomley
2010-12-22 20:23 ` Jesper Juhl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101118210642.GA24236@flint.arm.linux.org.uk \
--to=rmk@arm.linux.org.uk \
--cc=James.Bottomley@suse.de \
--cc=akpm@linux-foundation.org \
--cc=andmike@us.ibm.com \
--cc=davem@davemloft.net \
--cc=eric@andante.org \
--cc=jj@chaosbits.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox