From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matthew Wilcox Subject: Re: [PATCH repost 3] [SCSI] Retrieve the Caching mode page Date: Wed, 8 Dec 2010 09:00:28 -0700 Message-ID: <20101208160028.GB21909@parisc-linux.org> References: <1291823012.24312.52.camel@mulgrave.site> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Alan Stern Cc: James Bottomley , Greg KH , Luben Tuikov , Matthew Dharm , Linus Torvalds , linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, linux-usb@vger.kernel.org List-Id: linux-scsi@vger.kernel.org On Wed, Dec 08, 2010 at 10:57:46AM -0500, Alan Stern wrote: > In the strictest sense, there's always a possibility that any change > will crash _some_ device somewhere. In this case I believe the > probability is very low. Luben's patch does not change the commands > sent to a USB device; it only changes the kernel's interpretation of > the data sent back. Unless things are terribly badly broken, this > won't hurt. It doesn't change the _discovery_ commands sent to the device, but (I think ...) it will change the subsequent commands sent to the device; eg we'll now send it SYNCHRONISE CACHE when we wouldn't have before. I think it's low-risk too, and am in favour of seeing this patch applied. -- Matthew Wilcox Intel Open Source Technology Centre "Bill, look, we understand that you're interested in selling us this operating system, but compare it to ours. We can't possibly take such a retrograde step."