* [PATCH] Fix a couple of comments in scsi_request_fn
@ 2010-12-16 4:49 Matthew Wilcox
0 siblings, 0 replies; only message in thread
From: Matthew Wilcox @ 2010-12-16 4:49 UTC (permalink / raw)
To: linux-scsi
The IO request lock was killed in 2.5, and we don't take the shost lock
in scsi_dispatch_cmd any more.
Signed-off-by: Matthew Wilcox <willy@linux.intel.com>
diff --git a/drivers/scsi/scsi_lib.c b/drivers/scsi/scsi_lib.c
index 5b6bbae..9e881cd 100644
--- a/drivers/scsi/scsi_lib.c
+++ b/drivers/scsi/scsi_lib.c
@@ -1443,7 +1443,7 @@ static void scsi_softirq_done(struct request *rq)
*
* Returns: Nothing
*
- * Lock status: IO request lock assumed to be held when called.
+ * Lock status: request queue lock held, interrupts disabled
*/
static void scsi_request_fn(struct request_queue *q)
{
@@ -1530,10 +1530,6 @@ static void scsi_request_fn(struct request_queue *q)
scsi_target(sdev)->target_busy++;
shost->host_busy++;
- /*
- * XXX(hch): This is rather suboptimal, scsi_dispatch_cmd will
- * take the lock again.
- */
spin_unlock_irq(shost->host_lock);
/*
--
Matthew Wilcox Intel Open Source Technology Centre
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours. We can't possibly take such
a retrograde step."
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2010-12-16 4:49 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-12-16 4:49 [PATCH] Fix a couple of comments in scsi_request_fn Matthew Wilcox
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).