From: Matthew Wilcox <matthew@wil.cx>
To: Christoph Hellwig <hch@infradead.org>
Cc: linux-scsi@vger.kernel.org
Subject: Re: [RFC] uas host lock removal conversion
Date: Thu, 16 Dec 2010 07:00:36 -0700 [thread overview]
Message-ID: <20101216140035.GD1263@parisc-linux.org> (raw)
In-Reply-To: <20101216104458.GA5919@infradead.org>
On Thu, Dec 16, 2010 at 05:44:58AM -0500, Christoph Hellwig wrote:
> On Wed, Dec 15, 2010 at 10:02:57PM -0700, Matthew Wilcox wrote:
> >
> > I thought I'd take a crack at removing the host lock from uas. I think
> > I can now switch to using GFP_NOIO (since interrupts are enabled by
> > scsi_request_fn()), and I have to use _irq spinlocks to protect the list
> > that is modified from interrupt context (same reason :-).
>
> ->qeuecommand can be called from software interrupt context, so you'll
> need to stick to GFP_ATOMIC.
Ah, I couldn't find a path that did that. Could you point it out to me?
I'll send a patch to update that documentation.
--
Matthew Wilcox Intel Open Source Technology Centre
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours. We can't possibly take such
a retrograde step."
next prev parent reply other threads:[~2010-12-16 14:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-16 5:02 [RFC] uas host lock removal conversion Matthew Wilcox
2010-12-16 6:15 ` Land iscsi iser performance patches to upstream Zhiqi Tao
2011-01-03 22:32 ` Mike Christie
2011-01-04 7:17 ` Or Gerlitz
2011-01-04 7:22 ` Or Gerlitz
2010-12-16 10:44 ` [RFC] uas host lock removal conversion Christoph Hellwig
2010-12-16 14:00 ` Matthew Wilcox [this message]
2010-12-16 14:04 ` James Bottomley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101216140035.GD1263@parisc-linux.org \
--to=matthew@wil.cx \
--cc=hch@infradead.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).