From: Greg KH <gregkh@suse.de>
To: Bart Van Assche <bvanassche@acm.org>
Cc: linux-scsi@vger.kernel.org, scst-devel@lists.sourceforge.net,
James.Bottomley@suse.de,
Dmitry Torokhov <dmitry.torokhov@gmail.com>
Subject: Re: [PATCH 2a/7] SCST core / sysfs interface
Date: Tue, 21 Dec 2010 11:03:13 -0800 [thread overview]
Message-ID: <20101221190313.GB10717@suse.de> (raw)
In-Reply-To: <201012211105.49590.bvanassche@acm.org>
On Tue, Dec 21, 2010 at 11:05:49AM +0100, Bart Van Assche wrote:
> +#if defined(CONFIG_SCST_DEBUG) || defined(CONFIG_SCST_TRACING)
> +
> +static ssize_t scst_tgtt_trace_level_show(struct device_driver *drv, char *buf)
debug files belong in debugfs, not sysfs, please move them.
thanks,
greg k-h
next prev parent reply other threads:[~2010-12-21 19:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-21 10:05 [PATCH 2a/7] SCST core / sysfs interface Bart Van Assche
2010-12-21 19:01 ` Greg KH
2010-12-21 19:03 ` Greg KH [this message]
2010-12-22 12:41 ` Bart Van Assche
2010-12-22 19:32 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101221190313.GB10717@suse.de \
--to=gregkh@suse.de \
--cc=James.Bottomley@suse.de \
--cc=bvanassche@acm.org \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-scsi@vger.kernel.org \
--cc=scst-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox