Re: [PATCH 2a/7] SCST core / sysfs interface

[Greg KH <gregkh@suse.de>]

On Wed, Dec 22, 2010 at 01:41:35PM +0100, Bart Van Assche wrote:
> On Tue, Dec 21, 2010 at 8:03 PM, Greg KH <gregkh@suse.de> wrote:
> >
> > On Tue, Dec 21, 2010 at 11:05:49AM +0100, Bart Van Assche wrote:
> > > +#if defined(CONFIG_SCST_DEBUG) || defined(CONFIG_SCST_TRACING)
> > > +
> > > +static ssize_t scst_tgtt_trace_level_show(struct device_driver *drv, char *buf)
> >
> > debug files belong in debugfs, not sysfs, please move them.
> 
> Hello Greg,
> 
> Thanks for the feedback about Documentation/ABI. I will move the SCST
> sysfs documentation over there - in fact it's something I should
> already have done since you had already mentioned it in a previous
> e-mail.
> 
> Regarding the "trace_level" attributes in sysfs: are you aware that
> these are not only useful for kernel developers to debug the storage
> target code itself but also for storage target users who want to find
> out what a SCSI initiator is doing ? The "scsi", "mgmt" and
> "flow_control" trace levels are examples of this. Sometimes users (who
> are not SCST developers) have to enable these in order to find out
> what a SCSI initiator is doing. Are you sure you want these to be
> moved to debugfs ?

Yes.