From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg KH Subject: Re: [PATCH 2a/7] SCST core / sysfs interface Date: Wed, 22 Dec 2010 11:32:30 -0800 Message-ID: <20101222193230.GB29002@suse.de> References: <201012211105.49590.bvanassche@acm.org> <20101221190313.GB10717@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from cantor2.suse.de ([195.135.220.15]:52172 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751081Ab0LVTbs (ORCPT ); Wed, 22 Dec 2010 14:31:48 -0500 Content-Disposition: inline In-Reply-To: Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: Bart Van Assche Cc: linux-scsi@vger.kernel.org, scst-devel@lists.sourceforge.net, James.Bottomley@suse.de, Dmitry Torokhov , Vladislav Bolkhovitin On Wed, Dec 22, 2010 at 01:41:35PM +0100, Bart Van Assche wrote: > On Tue, Dec 21, 2010 at 8:03 PM, Greg KH wrote: > > > > On Tue, Dec 21, 2010 at 11:05:49AM +0100, Bart Van Assche wrote: > > > +#if defined(CONFIG_SCST_DEBUG) || defined(CONFIG_SCST_TRACING) > > > + > > > +static ssize_t scst_tgtt_trace_level_show(struct device_driver *drv, char *buf) > > > > debug files belong in debugfs, not sysfs, please move them. > > Hello Greg, > > Thanks for the feedback about Documentation/ABI. I will move the SCST > sysfs documentation over there - in fact it's something I should > already have done since you had already mentioned it in a previous > e-mail. > > Regarding the "trace_level" attributes in sysfs: are you aware that > these are not only useful for kernel developers to debug the storage > target code itself but also for storage target users who want to find > out what a SCSI initiator is doing ? The "scsi", "mgmt" and > "flow_control" trace levels are examples of this. Sometimes users (who > are not SCST developers) have to enable these in order to find out > what a SCSI initiator is doing. Are you sure you want these to be > moved to debugfs ? Yes.