Re: [linux-pm] [RFC] Deferred disk spinup during system resume

Maksim Rayskiy
2011-01-07T03:46:44Z

>> Okay, I moved EH scheduling to ata_qc_issue(). But since now  START
>> taskfile is
>> created in ata_eh_maybe_verify() I do not see why the same code has to
>> remain in ata_scsi_start_stop_xlat. Does it make sense?
>
> The taskfile you are to pass to the hardware is created in
> atapi_start_stop_xlat(), so you should not create a new taskfile in
> ata_eh_maybe_verify()
>

I can only see that the taskfile is being created in
ata_scsi_translate(). I want START request to return immediately, so I
need to schedule a deferred execution.
Do you suggest I create a new work_struct for this purpose (something
like link->spinup_task)? If I do that, I do not need to use
ata_port_schedule_eh() at all.

Thanks,
Maksim.
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html