linux-scsi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Stephen M. Cameron" <scameron@beardog.cce.hp.com>
To: james.bottomley@hansenpartnership.com
Cc: linux-scsi@vger.kernel.org, mike.miller@hp.com,
	linux-kernel@vger.kernel.org, thenzl@redhat.com,
	akpm@linux-foundation.org, smcameron@yahoo.com
Subject: [PATCH 02/11] hpsa: fixup DMA address before freeing.
Date: Thu, 06 Jan 2011 14:47:53 -0600	[thread overview]
Message-ID: <20110106204753.10753.51529.stgit@beardog.cce.hp.com> (raw)
In-Reply-To: <20110106204429.10753.92575.stgit@beardog.cce.hp.com>

From: Stephen M. Cameron <StephenM.Cameron>

Some low bits might have been set by the driver, causing
a message like this to come out:

 [   13.288062] ------------[ cut here ]------------
 [   13.293211] WARNING: at lib/dma-debug.c:803 check_unmap+0x1a1/0x654()
 [   13.300387] Hardware name: ProLiant DL180 G6
 [   13.305335] hpsa 0000:06:00.0: DMA-API: device driver tries to free
 DMA memory it has not allocated [device address=0x000000007f81e001]
 [size=640 bytes]

Signed-off-by: Stephen M. Cameron <scameron@beardog.cce.hp.com>
---
 drivers/scsi/hpsa.c     |    2 +-
 drivers/scsi/hpsa_cmd.h |    1 +
 2 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c
index e4b5f3c..e2089a3 100644
--- a/drivers/scsi/hpsa.c
+++ b/drivers/scsi/hpsa.c
@@ -2267,7 +2267,7 @@ static void cmd_special_free(struct ctlr_info *h, struct CommandList *c)
 	pci_free_consistent(h->pdev, sizeof(*c->err_info),
 			    c->err_info, (dma_addr_t) temp64.val);
 	pci_free_consistent(h->pdev, sizeof(*c),
-			    c, (dma_addr_t) c->busaddr);
+			    c, (dma_addr_t) (c->busaddr & DIRECT_LOOKUP_MASK));
 }
 
 #ifdef CONFIG_COMPAT
diff --git a/drivers/scsi/hpsa_cmd.h b/drivers/scsi/hpsa_cmd.h
index f5c4c3c..7910c14 100644
--- a/drivers/scsi/hpsa_cmd.h
+++ b/drivers/scsi/hpsa_cmd.h
@@ -265,6 +265,7 @@ struct ErrorInfo {
 
 #define DIRECT_LOOKUP_SHIFT 5
 #define DIRECT_LOOKUP_BIT 0x10
+#define DIRECT_LOOKUP_MASK (~((1 << DIRECT_LOOKUP_SHIFT) - 1))
 
 #define HPSA_ERROR_BIT          0x02
 struct ctlr_info; /* defined in hpsa.h */

  parent reply	other threads:[~2011-01-06 20:47 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-06 20:47 [PATCH 00/11] hpsa: updates, January 2011 Stephen M. Cameron
2011-01-06 20:47 ` [PATCH 01/11] hpsa: defend against zero sized buffers in passthru ioctls Stephen M. Cameron
2011-01-06 20:47 ` Stephen M. Cameron [this message]
2011-01-06 20:47 ` [PATCH 03/11] hpsa: Remove duplicate defines of DIRECT_LOOKUP_ constants Stephen M. Cameron
2011-01-06 20:48 ` [PATCH 04/11] hpsa: fix board status waiting code Stephen M. Cameron
2011-01-06 20:48 ` [PATCH 05/11] hpsa: Use kernel provided PCI state save and restore functions Stephen M. Cameron
2011-01-06 20:48 ` [PATCH 06/11] hpsa: limit commands allocated on reset_devices Stephen M. Cameron
2011-01-06 20:48 ` [PATCH 07/11] hpsa: do not reset unknown boards " Stephen M. Cameron
2011-01-06 20:48 ` [PATCH 08/11] hpsa: take the adapter lock in hpsa_wait_for_mode_change_ack Stephen M. Cameron
2011-01-06 20:48 ` [PATCH 09/11] hpsa: allow driver to put controller in either simple or performant mode Stephen M. Cameron
2011-01-06 20:48 ` [PATCH 10/11] hpsa: use usleep_range not msleep for small sleeps Stephen M. Cameron
2011-01-06 20:48 ` [PATCH 11/11] hpsa: Add a per controller commands_outstanding entry in /sys Stephen M. Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110106204753.10753.51529.stgit@beardog.cce.hp.com \
    --to=scameron@beardog.cce.hp.com \
    --cc=akpm@linux-foundation.org \
    --cc=james.bottomley@hansenpartnership.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=mike.miller@hp.com \
    --cc=smcameron@yahoo.com \
    --cc=thenzl@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).