From: Rolf Eike Beer <eike-kernel@sf-tec.de>
To: James Bottomley <James.Bottomley@suse.de>
Cc: "Nicholas A. Bellinger" <nab@linux-iscsi.org>,
linux-scsi <linux-scsi@vger.kernel.org>
Subject: Re: target: Fix excessive stack usage
Date: Fri, 7 Jan 2011 17:32:22 +0100 [thread overview]
Message-ID: <201101071732.27612.eike-kernel@sf-tec.de> (raw)
In-Reply-To: <1294187361.7879.21.camel@mulgrave.site>
[-- Attachment #1: Type: Text/Plain, Size: 340 bytes --]
James Bottomley wrote:
> @@ -1870,6 +1870,10 @@ static int __core_scsi3_update_aptpl_buf(
> "No Registrations or Reservations\n");
> return 0;
> }
> + tmp = kmalloc(1024, GFP_KERNEL);
> + if (!tmp)
> + return -1;
Shouldn't this return useful errorcodes all over the place instead of just -1?
Like -ENOMEM?
Eike
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
next prev parent reply other threads:[~2011-01-07 16:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-05 0:29 target: Fix excessive stack usage James Bottomley
2011-01-05 22:23 ` Nicholas A. Bellinger
2011-01-07 16:32 ` Rolf Eike Beer [this message]
2011-01-07 20:55 ` Nicholas A. Bellinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201101071732.27612.eike-kernel@sf-tec.de \
--to=eike-kernel@sf-tec.de \
--cc=James.Bottomley@suse.de \
--cc=linux-scsi@vger.kernel.org \
--cc=nab@linux-iscsi.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).