From: Christoph Hellwig <hch@infradead.org>
To: "Nicholas A. Bellinger" <nab@linux-iscsi.org>
Cc: Fubo Chen <fubo.chen@gmail.com>,
Christoph Hellwig <hch@infradead.org>,
linux-scsi <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH] target_core_mib.h move
Date: Tue, 18 Jan 2011 15:15:46 -0500 [thread overview]
Message-ID: <20110118201546.GA15970@infradead.org> (raw)
In-Reply-To: <1295381563.22813.429.camel@haakon2.linux-iscsi.org>
On Tue, Jan 18, 2011 at 12:12:43PM -0800, Nicholas A. Bellinger wrote:
> EXTRA_CFLAGS += -I$(srctree)/drivers/target/ -I$(srctree)/include/ -I$(srctree)/drivers/scsi/ -I$(srctree)/include/scsi/ -I$(srctree)/drivers/target/tcm_mvsas_tgt
>
> FYI, depending upon the age of the tcm_mod_builder.py in question , you
> may want to consider re-generating the fabric module skeleton with the
> latest code.
This shouldn't be nessecary. Except for special cases driver should
never need special include paths. I still don't see why the mib header
should be needed by drivers, but if it is it needs to move under
include/.
next prev parent reply other threads:[~2011-01-18 20:15 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-17 20:00 [PATCH] target_core_mib.h move Fubo Chen
2011-01-17 20:51 ` Christoph Hellwig
2011-01-17 22:32 ` Nicholas A. Bellinger
2011-01-18 16:58 ` Fubo Chen
2011-01-18 20:12 ` Nicholas A. Bellinger
2011-01-18 20:15 ` Christoph Hellwig [this message]
2011-01-18 21:02 ` Nicholas A. Bellinger
2011-01-22 14:49 ` Fubo Chen
2011-01-22 23:19 ` Nicholas A. Bellinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110118201546.GA15970@infradead.org \
--to=hch@infradead.org \
--cc=fubo.chen@gmail.com \
--cc=linux-scsi@vger.kernel.org \
--cc=nab@linux-iscsi.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox