From: Christoph Hellwig <hch@lst.de>
To: "Nicholas A. Bellinger" <nab@linux-iscsi.org>
Cc: linux-scsi <linux-scsi@vger.kernel.org>, Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH] target: Fix tcm_mod_builder.py default EXTRA_CFLAGS
Date: Tue, 18 Jan 2011 22:36:04 +0100 [thread overview]
Message-ID: <20110118213604.GA13063@lst.de> (raw)
In-Reply-To: <1295386222-12869-1-git-send-email-nab@linux-iscsi.org>
On Tue, Jan 18, 2011 at 01:30:22PM -0800, Nicholas A. Bellinger wrote:
> + buf = "EXTRA_CFLAGS += -I$(srctree)/include/ -I$(srctree)/drivers/target/" + fabric_mod_name + "\n\n"
-I$(srctree)/include/ is never needed, that's added automatically.
Similarly adding the directory of the driver itself (assuming that's
what the second one is supposed to be) is not needed either.
next prev parent reply other threads:[~2011-01-18 21:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-18 21:30 [PATCH] target: Fix tcm_mod_builder.py default EXTRA_CFLAGS Nicholas A. Bellinger
2011-01-18 21:36 ` Christoph Hellwig [this message]
2011-01-18 21:46 ` Nicholas A. Bellinger
2011-01-18 21:47 ` Christoph Hellwig
2011-01-18 22:03 ` Nicholas A. Bellinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110118213604.GA13063@lst.de \
--to=hch@lst.de \
--cc=linux-scsi@vger.kernel.org \
--cc=nab@linux-iscsi.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox