Re: [PATCH v4 1/3] scsi: Detailed I/O errors

Jens Axboe
2011-01-28T08:12:46Z

On 2011-01-27 23:54, Mike Snitzer wrote:
> On Thu, Jan 27 2011 at 5:41pm -0500,
> James Bottomley <James.Bottomley@suse.de> wrote:
>
>> On Thu, 2011-01-27 at 17:35 -0500, Mike Snitzer wrote:
>>> On Tue, Jan 18 2011 at 7:01am -0500,
>>> Hannes Reinecke <hare@suse.de> wrote:
>>>
>>>> On 01/18/2011 12:33 PM, Douglas Gilbert wrote:
>>>>
>>>> This patchset is primarily for fixing up multipathing,
>>>> which has the habit of retrying failed I/Os on the
>>>> next path. For some errors this is just pointless
>>>> (eg MEDIUM ERROR), for some errors this is the desired
>>>> behaviour (namely transport errors), and for others
>>>> this is positively damaging (persistent reservation
>>>> failures).
>>>> Just plain EIO simply don't cover the whole range :-)
>>>>
>>>>>
>>>>> BTW might "vulgo" be "ergo" [Latin: therefore]?
>>>>>
>>>> Nope. Correct etymology is from 'sermo vulgaris',
>>>> ie the language of the common people.
>>>> But maybe I should remove it for the next
>>>> round to avoid confusion.
>>>
>>> Is a new round even needed given there haven't been any code issues
>>> raised against v4?
>>>
>>> James, what are your thoughts on this patchset? Would be great to get
>>> this in scsi-misc for 2.6.39
>>>
>>> Please advise,
>>
>> Well, it covers three subsystems ... I was waiting for Alasdair and Jens
>> to ack ... but I bet they each were waiting for the other two to ack ...
>>
>> So, I'll take it if no objections.
>
> OK, I just sent a mail to jens and alasdair asking the same ;)

This one will be easier just to take in the SCSI tree, since there's so
little risk for conflict. You can add my acked-by to the patches.

--
Jens Axboe