From: Matthew Garrett <mjg59@srcf.ucam.org>
To: "Miller, Mike (OS Dev)" <Mike.Miller@hp.com>
Cc: ISS StorageDev <iss_storagedev@hp.com>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH 2/2] cciss: Disable ASPM
Date: Wed, 9 Feb 2011 20:45:19 +0000 [thread overview]
Message-ID: <20110209204519.GA20661@srcf.ucam.org> (raw)
In-Reply-To: <0F5B06BAB751E047AB5C87D1F77A77887D479C5C9C@GVW0547EXC.americas.hpqcorp.net>
On Wed, Feb 09, 2011 at 08:35:02PM +0000, Miller, Mike (OS Dev) wrote:
> ASPM is supposed to be fixed on both Proliant and Smart Array by the
> next generation of hardware. If that comes to fruition I suppose we
> could make this patch conditional based on whether the underlying hw
> really supports ASPM. Other than that this looks good.
Yes, ideally we'd make this conditional on the ID.
> Matthew, if Proliant BIOS tells the OS that ASPM is not supported does
> the OS honor that and not attempt to use ASPM? I know there was a time
> (maybe still is) when that bit in the ACPI table was not being set so
> rhel6 tried to use ASPM and hence the BZ you mention. Sorry, but I
> can't recall the proper terminology for the ACPI table related stuff.
We ended up identifying the heuristic that HP were using to disable ASPM
on Windows and that's now implemented upstream, but if this hardware's
available on cards then there's the possibility that someone might try
it on a machine where ASPM isn't explicitly disabled.
--
Matthew Garrett | mjg59@srcf.ucam.org
prev parent reply other threads:[~2011-02-09 20:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-09 18:07 [PATCH 1/2] hpsa: Disable ASPM Matthew Garrett
2011-02-09 18:07 ` [PATCH 2/2] cciss: " Matthew Garrett
2011-02-09 20:35 ` Miller, Mike (OS Dev)
2011-02-09 20:45 ` Matthew Garrett [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110209204519.GA20661@srcf.ucam.org \
--to=mjg59@srcf.ucam.org \
--cc=Mike.Miller@hp.com \
--cc=iss_storagedev@hp.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).