From: "Stephen M. Cameron" <scameron@beardog.cce.hp.com>
To: james.bottomley@hansenpartnership.com
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
mike.mikem@beardog.cce.hp.com, thenzl@redhat.com,
akpm@linux-foundation.org, smcameron@yahoo.com
Subject: [PATCH 6/6] hpsa: fix bad comparison
Date: Tue, 15 Feb 2011 15:33:13 -0600 [thread overview]
Message-ID: <20110215213313.5407.42792.stgit@beardog.cce.hp.com> (raw)
In-Reply-To: <20110215212856.5407.3438.stgit@beardog.cce.hp.com>
From: Dan Carpenter <error27@gmail.com>
'!' has higher precedence than '&'. CFGTBL_ChangeReq is 0x1 so the
original code is equivelent to if (!doorbell_value) {...
Signed-off-by: Dan Carpenter <error27@gmail.com>
Acked-by: Stephen M. Cameron <scameron@beardog.cce.hp.com>
---
drivers/scsi/hpsa.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c
index eb6938f..c30591f 100644
--- a/drivers/scsi/hpsa.c
+++ b/drivers/scsi/hpsa.c
@@ -3614,7 +3614,7 @@ static void __devinit hpsa_wait_for_mode_change_ack(struct ctlr_info *h)
spin_lock_irqsave(&h->lock, flags);
doorbell_value = readl(h->vaddr + SA5_DOORBELL);
spin_unlock_irqrestore(&h->lock, flags);
- if (!doorbell_value & CFGTBL_ChangeReq)
+ if (!(doorbell_value & CFGTBL_ChangeReq))
break;
/* delay and try again */
usleep_range(10000, 20000);
prev parent reply other threads:[~2011-02-15 21:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-15 21:32 [PATCH 0/6] hpsa: Feb 15, 2011 updates Stephen M. Cameron
2011-02-15 21:32 ` [PATCH 1/6] hpsa: do not re-order commands in internal queues Stephen M. Cameron
2011-02-15 21:32 ` [PATCH 2/6] hpsa: make hpsa.hpsa_simple_mode=1 module parameter actually work Stephen M. Cameron
2011-02-15 21:32 ` [PATCH 3/6] hpsa: Add transport_mode host attribute in /sys Stephen M. Cameron
2011-02-15 21:33 ` [PATCH 4/6] hpsa: Inform controller we are using 32-bit tags Stephen M. Cameron
2011-02-15 21:33 ` [PATCH 5/6] hpsa: Do not attempt kdump if we detect resetting controller failed Stephen M. Cameron
2011-02-15 21:33 ` Stephen M. Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110215213313.5407.42792.stgit@beardog.cce.hp.com \
--to=scameron@beardog.cce.hp.com \
--cc=akpm@linux-foundation.org \
--cc=james.bottomley@hansenpartnership.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=mike.mikem@beardog.cce.hp.com \
--cc=smcameron@yahoo.com \
--cc=thenzl@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox