From: Randy Dunlap <randy.dunlap@oracle.com>
To: Chen Liu <chenliunju@gmail.com>
Cc: linux-kernel@vger.kernel.org, scsi <linux-scsi@vger.kernel.org>
Subject: Re: [Patch] Patch for bug 13547
Date: Wed, 2 Mar 2011 11:37:10 -0800 [thread overview]
Message-ID: <20110302113710.f63fd8ee.randy.dunlap@oracle.com> (raw)
In-Reply-To: <AANLkTikL5Fc-4bLRCBj+JB8T9XY1BHaYZrjYoC_y_ki4@mail.gmail.com>
On Wed, 2 Mar 2011 14:28:51 -0500 Chen Liu wrote:
[adding linux-scsi]
> Hi everyone,
>
> There is a patch generated by the tool R2Fix for bug 13547. Could you
> take a look at them? Thanks!
> The patch:
> --- linux-2.6.30/drivers/scsi/FlashPoint.c 2009-06-09
> 23:05:27.000000000 -0400
> +++ /tmp/cocci-output-726-34f8c9-FlashPoint.c 2011-02-23
> 22:05:29.765164083 -0500
> @@ -1212,7 +1212,7 @@ static unsigned long FlashPoint_Hardware
>
> ioport = pCardInfo->si_baseaddr;
>
> - for (thisCard = 0; thisCard <= MAX_CARDS; thisCard++) {
> + for (thisCard = 0; thisCard < MAX_CARDS; thisCard++) {
>
> if (thisCard == MAX_CARDS) {
Please fix the R2Fix tool to generate patches correctly:
The +++ file name is incorrect.
The patch is whitespace-damaged. gmail isn't good at preserving
tabs -- they have been converted to spaces, so the patch does not
apply cleanly.
If this patch is applied, how does this function return FAILURE?
I don't think that is does -- I think the patch is bad.
---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
next parent reply other threads:[~2011-03-02 19:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <AANLkTikL5Fc-4bLRCBj+JB8T9XY1BHaYZrjYoC_y_ki4@mail.gmail.com>
2011-03-02 19:37 ` Randy Dunlap [this message]
2011-03-02 21:44 ` [Patch] Patch for bug 13547 Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110302113710.f63fd8ee.randy.dunlap@oracle.com \
--to=randy.dunlap@oracle.com \
--cc=chenliunju@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox