From mboxrd@z Thu Jan 1 00:00:00 1970 From: Randy Dunlap Subject: Re: [Patch] Patch for bug 13547 Date: Wed, 2 Mar 2011 11:37:10 -0800 Message-ID: <20110302113710.f63fd8ee.randy.dunlap@oracle.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Chen Liu Cc: linux-kernel@vger.kernel.org, scsi List-Id: linux-scsi@vger.kernel.org On Wed, 2 Mar 2011 14:28:51 -0500 Chen Liu wrote: [adding linux-scsi] > Hi everyone, >=20 > There is a patch generated by the tool R2Fix for bug 13547. Could you > take a look at them? Thanks! > The patch: > --- linux-2.6.30/drivers/scsi/FlashPoint.c=A0=A0=A0 2009-06-09 > 23:05:27.000000000 -0400 > +++ /tmp/cocci-output-726-34f8c9-FlashPoint.c=A0=A0=A0 2011-02-23 > 22:05:29.765164083 -0500 > @@ -1212,7 +1212,7 @@ static unsigned long FlashPoint_Hardware >=20 > =A0=A0=A0=A0 ioport =3D pCardInfo->si_baseaddr; >=20 > -=A0=A0=A0 for (thisCard =3D 0; thisCard <=3D MAX_CARDS; thisCard++) = { > +=A0=A0=A0 for (thisCard =3D 0; thisCard < MAX_CARDS; thisCard++) { >=20 > =A0=A0=A0=A0 =A0=A0=A0 if (thisCard =3D=3D MAX_CARDS) { Please fix the R2Fix tool to generate patches correctly: The +++ file name is incorrect. The patch is whitespace-damaged. gmail isn't good at preserving tabs -- they have been converted to spaces, so the patch does not apply cleanly. If this patch is applied, how does this function return FAILURE? I don't think that is does -- I think the patch is bad. --- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your cod= e ***