From: Christoph Hellwig <hch@infradead.org>
To: Dan Williams <dan.j.williams@intel.com>
Cc: dave.jiang@intel.com, linux-scsi@vger.kernel.org,
jacek.danecki@intel.com, ed.ciechanowski@intel.com,
jeffrey.d.skirvin@intel.com, edmund.nadolski@intel.com
Subject: [PATCH, RFC 0/2] scic: remove pointless stuctures
Date: Mon, 28 Mar 2011 09:20:46 -0400 [thread overview]
Message-ID: <20110328132046.GA497@infradead.org> (raw)
In-Reply-To: <20110328000754.GA28347@infradead.org>
Start killing off the pointless sci_base* structures which do nothing
but causing a lot of unreadable code by converting forth and back
between them and the real structures.
I've done the sci_base_controller, and sci_base_request on a rainy
sunday afternoon, but the port, phy and remote device also need the
same treatment. And after that the sci_base_object crap needs to
go in favour of just using container_of or properly typed pointers.
But I'll rather leave that to you Intel guys, spending more time
on this codebase won't be good for my mental health.
next prev parent reply other threads:[~2011-03-28 13:20 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-28 0:07 [PATCH] scic: remove mmio wrappers Christoph Hellwig
2011-03-28 13:20 ` Christoph Hellwig [this message]
2011-03-28 13:21 ` [PATCH 1/2] isci: remove base_controller abstraction Christoph Hellwig
2011-03-31 21:21 ` Dan Williams
2011-03-28 13:21 ` [PATCH 2/2] isci: remove base_request abstraction Christoph Hellwig
2011-03-31 22:14 ` Dan Williams
2011-04-01 13:11 ` Christoph Hellwig
2011-03-31 22:24 ` [PATCH, RFC 0/2] scic: remove pointless stuctures Dan Williams
2011-03-31 1:43 ` [PATCH] scic: remove mmio wrappers Dan Williams
2011-03-31 6:31 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110328132046.GA497@infradead.org \
--to=hch@infradead.org \
--cc=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=ed.ciechanowski@intel.com \
--cc=edmund.nadolski@intel.com \
--cc=jacek.danecki@intel.com \
--cc=jeffrey.d.skirvin@intel.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).