From: Christoph Hellwig <hch@infradead.org>
To: Dan Williams <dan.j.williams@intel.com>
Cc: james.bottomley@suse.de, dave.jiang@intel.com,
linux-scsi@vger.kernel.org, jacek.danecki@intel.com,
ed.ciechanowski@intel.com, jeffrey.d.skirvin@intel.com,
edmund.nadolski@intel.com
Subject: Re: [RFC PATCH 10/10] isci/core: common definitions and utility functions
Date: Wed, 30 Mar 2011 10:37:52 -0400 [thread overview]
Message-ID: <20110330143752.GA31559@infradead.org> (raw)
In-Reply-To: <20110310105511.6485.41512.stgit@localhost6.localdomain6>
> +/**
> + * SCIC_SWAP_DWORD() -
> + *
> + * Normal byte swap macro
> + */
> +#define SCIC_SWAP_DWORD(x) \
> + (\
> + (((x) >> 24) & 0x000000FF) \
> + | (((x) >> 8) & 0x0000FF00) \
> + | (((x) << 8) & 0x00FF0000) \
> + | (((x) << 24) & 0xFF000000) \
> + )
Duplicates the kernel byte sewap macros. Even worse it's doing an
unconditional swap instead of a conditional one if the platform
is big endian. While we're at it this driver seems to lack any
kind of endiness awareness, but that's probably to be expected
coming from intel. Isn't the new chipset generation supposed to
support ia64 as well, which is capable of running in big endian
mode?
next prev parent reply other threads:[~2011-03-30 14:37 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-10 10:54 [RFC PATCH 00/10] isci: core Dan Williams
2011-03-10 10:54 ` [RFC PATCH 01/10] isci/core: controller Dan Williams
2011-03-10 10:54 ` [RFC PATCH 02/10] isci/core: phy Dan Williams
2011-03-10 10:54 ` [RFC PATCH 03/10] isci/core: port Dan Williams
2011-03-10 10:54 ` [RFC PATCH 04/10] isci/core: remote device Dan Williams
2011-03-10 10:54 ` [RFC PATCH 05/10] isci/core: remote node context Dan Williams
2011-03-10 10:54 ` [RFC PATCH 06/10] isci/core: stp Dan Williams
2011-03-10 10:54 ` [RFC PATCH 07/10] isci/core: request (general, ssp and smp) Dan Williams
2011-03-10 10:55 ` [RFC PATCH 08/10] isci/core: unsolicited frame handling and registers Dan Williams
2011-03-10 10:55 ` [RFC PATCH 09/10] isci/core: base state machine and memory descriptors Dan Williams
2011-03-10 10:55 ` [RFC PATCH 10/10] isci/core: common definitions and utility functions Dan Williams
2011-03-30 14:37 ` Christoph Hellwig [this message]
2011-03-15 17:47 ` [RFC PATCH 00/10] isci: core Jeff Garzik
2011-03-15 17:55 ` Christoph Hellwig
2011-03-15 18:08 ` Jeff Garzik
2011-03-15 20:13 ` Dan Williams
2011-03-15 21:04 ` Jeff Garzik
2011-03-18 15:56 ` Christoph Hellwig
2011-03-19 6:19 ` Dan Williams
2011-03-27 22:32 ` Christoph Hellwig
2011-03-30 1:22 ` Dan Williams
2011-03-30 7:23 ` Christoph Hellwig
2011-03-31 0:20 ` Dan Williams
2011-03-31 6:32 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110330143752.GA31559@infradead.org \
--to=hch@infradead.org \
--cc=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=ed.ciechanowski@intel.com \
--cc=edmund.nadolski@intel.com \
--cc=jacek.danecki@intel.com \
--cc=james.bottomley@suse.de \
--cc=jeffrey.d.skirvin@intel.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).