From: Christoph Hellwig <hch@infradead.org>
To: Dan Williams <dan.j.williams@intel.com>
Cc: Christoph Hellwig <hch@infradead.org>,
dave.jiang@intel.com, linux-scsi@vger.kernel.org,
jacek.danecki@intel.com, ed.ciechanowski@intel.com,
jeffrey.d.skirvin@intel.com, edmund.nadolski@intel.com
Subject: Re: [PATCH] scic: remove mmio wrappers
Date: Thu, 31 Mar 2011 02:31:14 -0400 [thread overview]
Message-ID: <20110331063114.GB32336@infradead.org> (raw)
In-Reply-To: <AANLkTinqdo6q_EUCih74iZzsiccL1V-nk8qatxRVY8ax@mail.gmail.com>
On Wed, Mar 30, 2011 at 06:43:45PM -0700, Dan Williams wrote:
> Smoketests ok, applied, but without the hunk below, which gives away
> the fact that this was automated to some extent.
This wasn't automated, but I don't think leaving stale references to
macros that have been removed is a good idea. Which btw is something
that can be seen a lot in the current codebase - there's tons of
comments referring to non-existing types. But most of these are rather
pointless boilerplates explaining the signatures operation vectors the
Nth time.
prev parent reply other threads:[~2011-03-31 6:31 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-28 0:07 [PATCH] scic: remove mmio wrappers Christoph Hellwig
2011-03-28 13:20 ` [PATCH, RFC 0/2] scic: remove pointless stuctures Christoph Hellwig
2011-03-28 13:21 ` [PATCH 1/2] isci: remove base_controller abstraction Christoph Hellwig
2011-03-31 21:21 ` Dan Williams
2011-03-28 13:21 ` [PATCH 2/2] isci: remove base_request abstraction Christoph Hellwig
2011-03-31 22:14 ` Dan Williams
2011-04-01 13:11 ` Christoph Hellwig
2011-03-31 22:24 ` [PATCH, RFC 0/2] scic: remove pointless stuctures Dan Williams
2011-03-31 1:43 ` [PATCH] scic: remove mmio wrappers Dan Williams
2011-03-31 6:31 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110331063114.GB32336@infradead.org \
--to=hch@infradead.org \
--cc=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=ed.ciechanowski@intel.com \
--cc=edmund.nadolski@intel.com \
--cc=jacek.danecki@intel.com \
--cc=jeffrey.d.skirvin@intel.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).