From: Matthew Wilcox <matthew@wil.cx>
To: Christoph Hellwig <hch@infradead.org>
Cc: Matthew Wilcox <willy@linux.intel.com>, linux-scsi@vger.kernel.org
Subject: Re: [PATCH 1/3] SCSI: Make cmd_serial_number an atomic
Date: Sat, 2 Apr 2011 15:02:40 -0600 [thread overview]
Message-ID: <20110402210240.GD7286@parisc-linux.org> (raw)
In-Reply-To: <20110402133643.GB18990@infradead.org>
On Sat, Apr 02, 2011 at 09:36:43AM -0400, Christoph Hellwig wrote:
> On Fri, Apr 01, 2011 at 04:20:51PM -0400, Matthew Wilcox wrote:
> >
> > In preparation for moving some drivers out from under the host_lock,
> > make cmd_serial_number an atomic.
>
> The right fix is to stop abusing cmd_serial_nubmer in those few
> drivers, and use a driver-private and more scalable lookup data
> structure than a linear list search.
>
> And yes, I promised to at least move cmd_serial_number into these
> drivers long time ago - time to get back to that.
Fair enough, but you're making the perfect the enemy of the good.
How about putting this patch in for now (since it harms nothing), and
then it'll all go away when you delete cmd_serial_number?
--
Matthew Wilcox Intel Open Source Technology Centre
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours. We can't possibly take such
a retrograde step."
next prev parent reply other threads:[~2011-04-02 21:02 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-01 20:20 [PATCH 1/3] SCSI: Make cmd_serial_number an atomic Matthew Wilcox
2011-04-02 13:36 ` Christoph Hellwig
2011-04-02 13:51 ` James Bottomley
2011-04-02 18:10 ` Jeff Garzik
2011-04-02 21:02 ` Matthew Wilcox [this message]
2011-04-03 11:00 ` Christoph Hellwig
2011-04-03 12:14 ` James Bottomley
2011-04-03 13:15 ` Matthew Wilcox
2011-04-03 13:33 ` Christoph Hellwig
2011-04-03 19:54 ` James Bottomley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110402210240.GD7286@parisc-linux.org \
--to=matthew@wil.cx \
--cc=hch@infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=willy@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).