From: Christoph Hellwig <hch@infradead.org>
To: James.Bottomley@suse.de
Cc: linux-scsi@vger.kernel.org, Eric.Moore@lsi.com
Subject: [PATCH 3/4] mpt2sas: do not check serial_number in the abort handler
Date: Mon, 4 Apr 2011 09:42:30 -0400 [thread overview]
Message-ID: <20110404134230.GC32522@infradead.org> (raw)
In-Reply-To: <20110404134203.GA29525@infradead.org>
The SCSI midlayer stops all command processing when in error handling, which
means there is no chance for command reuse when the abort handler is called.
Signed-off-by: Christoph Hellwig <hch@lst.de>
Index: linux-2.6/drivers/scsi/mpt2sas/mpt2sas_scsih.c
===================================================================
--- linux-2.6.orig/drivers/scsi/mpt2sas/mpt2sas_scsih.c 2011-04-04 06:25:05.892763786 -0700
+++ linux-2.6/drivers/scsi/mpt2sas/mpt2sas_scsih.c 2011-04-04 06:25:24.592763544 -0700
@@ -2133,8 +2133,7 @@ mpt2sas_scsih_issue_tm(struct MPT2SAS_AD
switch (type) {
case MPI2_SCSITASKMGMT_TASKTYPE_ABORT_TASK:
scmd_lookup = _scsih_scsi_lookup_get(ioc, smid_task);
- if (scmd_lookup && (scmd_lookup->serial_number ==
- scmd->serial_number))
+ if (scmd_lookup)
rc = FAILED;
else
rc = SUCCESS;
next prev parent reply other threads:[~2011-04-04 13:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-04 13:42 [PATCH 0/4] cmd->serial_number removal, part 1 Christoph Hellwig
2011-04-04 13:42 ` [PATCH 1/4] scsi: remove cmd->serial_number litter Christoph Hellwig
2011-04-04 13:42 ` [PATCH 2/4] usb-storage: do not increment cmd->serial_number Christoph Hellwig
2011-04-04 13:42 ` Christoph Hellwig [this message]
2011-04-04 14:20 ` [PATCH 3/4] mpt2sas: do not check serial_number in the abort handler Moore, Eric
2011-04-04 13:42 ` [PATCH 4/4] fusion: " Christoph Hellwig
2011-05-25 13:41 ` Desai, Kashyap
2011-05-25 15:18 ` James Bottomley
2011-05-25 15:22 ` Desai, Kashyap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110404134230.GC32522@infradead.org \
--to=hch@infradead.org \
--cc=Eric.Moore@lsi.com \
--cc=James.Bottomley@suse.de \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).