From: Christoph Hellwig <hch@infradead.org>
To: James.Bottomley@suse.de
Cc: linux-scsi@vger.kernel.org, Eric.Moore@lsi.com
Subject: [PATCH 4/4] fusion: do not check serial_number in the abort handler
Date: Mon, 4 Apr 2011 09:42:41 -0400 [thread overview]
Message-ID: <20110404134241.GD32522@infradead.org> (raw)
In-Reply-To: <20110404134203.GA29525@infradead.org>
The SCSI midlayer stops all command processing when in error handling, which
means there is no chance for command reuse when the abort handler is called.
Signed-off-by: Christoph Hellwig <hch@lst.de>
Index: linux-2.6/drivers/message/fusion/mptscsih.c
===================================================================
--- linux-2.6.orig/drivers/message/fusion/mptscsih.c 2011-04-04 06:25:45.526096602 -0700
+++ linux-2.6/drivers/message/fusion/mptscsih.c 2011-04-04 06:26:07.036096337 -0700
@@ -1773,7 +1773,6 @@ mptscsih_abort(struct scsi_cmnd * SCpnt)
int scpnt_idx;
int retval;
VirtDevice *vdevice;
- ulong sn = SCpnt->serial_number;
MPT_ADAPTER *ioc;
/* If we can't locate our host adapter structure, return FAILED status.
@@ -1859,8 +1858,7 @@ mptscsih_abort(struct scsi_cmnd * SCpnt)
vdevice->vtarget->id, vdevice->lun,
ctx2abort, mptscsih_get_tm_timeout(ioc));
- if (SCPNT_TO_LOOKUP_IDX(ioc, SCpnt) == scpnt_idx &&
- SCpnt->serial_number == sn) {
+ if (SCPNT_TO_LOOKUP_IDX(ioc, SCpnt) == scpnt_idx) {
dtmprintk(ioc, printk(MYIOC_s_DEBUG_FMT
"task abort: command still in active list! (sc=%p)\n",
ioc->name, SCpnt));
@@ -1873,9 +1871,9 @@ mptscsih_abort(struct scsi_cmnd * SCpnt)
}
out:
- printk(MYIOC_s_INFO_FMT "task abort: %s (rv=%04x) (sc=%p) (sn=%ld)\n",
+ printk(MYIOC_s_INFO_FMT "task abort: %s (rv=%04x) (sc=%p)\n",
ioc->name, ((retval == SUCCESS) ? "SUCCESS" : "FAILED"), retval,
- SCpnt, SCpnt->serial_number);
+ SCpnt);
return retval;
}
next prev parent reply other threads:[~2011-04-04 13:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-04 13:42 [PATCH 0/4] cmd->serial_number removal, part 1 Christoph Hellwig
2011-04-04 13:42 ` [PATCH 1/4] scsi: remove cmd->serial_number litter Christoph Hellwig
2011-04-04 13:42 ` [PATCH 2/4] usb-storage: do not increment cmd->serial_number Christoph Hellwig
2011-04-04 13:42 ` [PATCH 3/4] mpt2sas: do not check serial_number in the abort handler Christoph Hellwig
2011-04-04 14:20 ` Moore, Eric
2011-04-04 13:42 ` Christoph Hellwig [this message]
2011-05-25 13:41 ` [PATCH 4/4] fusion: " Desai, Kashyap
2011-05-25 15:18 ` James Bottomley
2011-05-25 15:22 ` Desai, Kashyap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110404134241.GD32522@infradead.org \
--to=hch@infradead.org \
--cc=Eric.Moore@lsi.com \
--cc=James.Bottomley@suse.de \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).