From: Tejun Heo <tj@kernel.org>
To: Amit Shah <amit.shah@redhat.com>
Cc: linux-kernel@vger.kernel.org, Jens Axboe <axboe@kernel.dk>,
"James E.J. Bottomley" <James.Bottomley@suse.de>,
linux-scsi@vger.kernel.org, Markus Armbruster <armbru@redhat.com>,
Stefan Hajnoczi <stefanha@gmail.com>
Subject: Re: [PATCH] sr: Ensure disk is revalidated when media changes
Date: Wed, 6 Apr 2011 03:06:20 -0700 [thread overview]
Message-ID: <20110406100620.GA4142@mtj.dyndns.org> (raw)
In-Reply-To: <20110405065129.GC2872@amit-x200.redhat.com>
On Tue, Apr 05, 2011 at 12:21:30PM +0530, Amit Shah wrote:
> > But I don't think this is the correct place to do it. The problem
> > happens because block layer consumes the event but doesn't remember it
> > when the time for revalidation comes. It should be done by block
> > layer, not sr. Hmmm... looking at the code, the new disk event code
> > should handle this correctly. Was 2.6.38 showing the problem too?
>
> Yes, 2.6.38 shows the same problem. I went back to ancient kernels
> (2.6.31 on Fedora 11-alpha) which had the previous media_changed
> infrastructure and those places too show the same behaviour (with the
> TEST_UNIT_READY way of detecting media changes).
Can you please the patch attached in the following bz and see whether
it makes any difference?
https://bugzilla.kernel.org/show_bug.cgi?id=13029
Thanks.
--
tejun
next prev parent reply other threads:[~2011-04-06 10:06 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-31 18:20 [PATCH] sr: Ensure disk is revalidated when media changes Amit Shah
2011-04-01 15:43 ` Tejun Heo
2011-04-05 6:51 ` Amit Shah
2011-04-06 10:06 ` Tejun Heo [this message]
2011-04-06 11:02 ` Amit Shah
2011-04-08 11:37 ` Stefan Hajnoczi
2011-04-08 16:20 ` Tejun Heo
2011-04-08 16:43 ` Stefan Hajnoczi
2011-04-08 16:52 ` Tejun Heo
2011-04-12 4:51 ` Amit Shah
2011-04-12 8:16 ` Stefan Hajnoczi
2011-04-12 8:36 ` Amit Shah
2011-04-05 14:46 ` Amit Shah
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110406100620.GA4142@mtj.dyndns.org \
--to=tj@kernel.org \
--cc=James.Bottomley@suse.de \
--cc=amit.shah@redhat.com \
--cc=armbru@redhat.com \
--cc=axboe@kernel.dk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).