linux-scsi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Alexey Dobriyan <adobriyan@gmail.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: akpm@linux-foundation.org, James.Bottomley@hansenpartnership.com,
	linux-scsi@vger.kernel.org, axboe@kernel.dk
Subject: Re: 2.6.39-rc6: cdrecord oops
Date: Wed, 4 May 2011 22:45:56 +0300	[thread overview]
Message-ID: <20110504194555.GA4492@p183> (raw)
In-Reply-To: <BANLkTi=-Qv4eUbhS0QGdyX9Q8oQ8VYcD5A@mail.gmail.com>

On Wed, May 04, 2011 at 12:32:50PM -0700, Linus Torvalds wrote:
> On Wed, May 4, 2011 at 12:07 PM, Alexey Dobriyan <adobriyan@gmail.com> wrote:
> > Got one at the very end of burning session (haven't tried to reproduce yet).
> > Apparently happened when cdrecord tried to open the door.
> >
> >        __lock_acquire
> >        lock_acquire
> >        _raw_spin_lock_irq
> >        blk_get_request
> 
> Hmm. That would be the
> 
>   spin_lock_irq(q->queue_lock);
> 
> in there, I'm not seeing any other spinlock.
> 
> >        scsi_execute
> >        scsi_set_medium_removal
> >        sr_lock_door
> >        cdrom_release
> >        sr_block_release
> >        __blk_dev_put
> >        blkdev_put
> >        blkdev_close
> >        fput
> >        filp_close
> >        sys_close
> >
> > comm: cdrecord
> > RAX was small number like 0x46(?)
> > RBX 6b6b6b6b6b6b6b83
> > RDI 6b6b6b6b6b6b6b83
> 
> And that implies that 'q' has been free'd before it's used, and you
> have SLUB-debugging turned on.
> 
> > This model is USB device.
> 
> Hmm. It looks a bit odd that cdrom_release() does the ->release call
> before it does the ->tray_move thing, but I don't think that's it.
> 
> Jens/James: What's the sequence to blk_cleanup_queue() for a SCSI
> CD-ROM? It really does look like we're releasing the queue before
> we're done with it.

Second time, burning finished to the end successfully.
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

      reply	other threads:[~2011-05-04 19:46 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-04 19:07 2.6.39-rc6: cdrecord oops Alexey Dobriyan
2011-05-04 19:32 ` Linus Torvalds
2011-05-04 19:45   ` Alexey Dobriyan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110504194555.GA4492@p183 \
    --to=adobriyan@gmail.com \
    --cc=James.Bottomley@hansenpartnership.com \
    --cc=akpm@linux-foundation.org \
    --cc=axboe@kernel.dk \
    --cc=linux-scsi@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).