From: Christoph Hellwig <hch@infradead.org>
To: Samuel Thibault <samuel.thibault@ens-lyon.org>,
James.Bottomley@suse.de, linux-kernel@vger.kernel.org,
linux-scsi@vger.kernel.org, akpm@linux-foundation.org
Subject: Re: [PATCH]: Fix Ultrastor asm snippet
Date: Fri, 20 May 2011 09:02:15 -0400 [thread overview]
Message-ID: <20110520130215.GB3428@infradead.org> (raw)
In-Reply-To: <20110518150605.GA25262@const.bordeaux.inria.fr>
On Wed, May 18, 2011 at 05:06:05PM +0200, Samuel Thibault wrote:
> Commit 1292500b replaced
>
> "=m" (*field) : "1" (*field)
>
> with
>
> "=m" (*field) :
>
> with comment "The following patch fixes it by using the '+' operator on
> the (*field) operand, marking it as read-write to gcc."
> '+' was actually forgotten. This really puts it.
Do you actually have the hardware or was this just a code audit?
I have the strong suspicion that this driver is pretty much dead and
bitrotting.
next prev parent reply other threads:[~2011-05-20 13:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-18 15:06 [PATCH]: Fix Ultrastor asm snippet Samuel Thibault
2011-05-20 13:02 ` Christoph Hellwig [this message]
2011-05-20 13:04 ` Samuel Thibault
2011-05-20 13:24 ` Alan Cox
2011-05-24 17:28 ` James Bottomley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110520130215.GB3428@infradead.org \
--to=hch@infradead.org \
--cc=James.Bottomley@suse.de \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=samuel.thibault@ens-lyon.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).