From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH]: Fix Ultrastor asm snippet Date: Fri, 20 May 2011 09:02:15 -0400 Message-ID: <20110520130215.GB3428@infradead.org> References: <20110518150605.GA25262@const.bordeaux.inria.fr> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20110518150605.GA25262@const.bordeaux.inria.fr> Sender: linux-kernel-owner@vger.kernel.org To: Samuel Thibault , James.Bottomley@suse.de, linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, akpm@linux-foundation.org List-Id: linux-scsi@vger.kernel.org On Wed, May 18, 2011 at 05:06:05PM +0200, Samuel Thibault wrote: > Commit 1292500b replaced > > "=m" (*field) : "1" (*field) > > with > > "=m" (*field) : > > with comment "The following patch fixes it by using the '+' operator on > the (*field) operand, marking it as read-write to gcc." > '+' was actually forgotten. This really puts it. Do you actually have the hardware or was this just a code audit? I have the strong suspicion that this driver is pretty much dead and bitrotting.