linux-scsi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [patch 6/6] drivers/scsi/ultrastor.c: fix asm snippet
@ 2011-05-23 22:29 akpm
  0 siblings, 0 replies; only message in thread
From: akpm @ 2011-05-23 22:29 UTC (permalink / raw)
  To: James.Bottomley; +Cc: linux-scsi, akpm, samuel.thibault, deweerdt

From: Samuel Thibault <samuel.thibault@ens-lyon.org>

Commit 1292500b ("ultrastor: clean up inline asm warnings") replaced

"=m" (*field) : "1" (*field)

with

"=m" (*field) :

with comment "The following patch fixes it by using the '+' operator on
the (*field) operand, marking it as read-write to gcc."
'+' was actually forgotten.  This really puts it.

Signed-off-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
Cc: Frederik Deweerdt <deweerdt@free.fr>
Cc: James Bottomley <James.Bottomley@HansenPartnership.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 drivers/scsi/ultrastor.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff -puN drivers/scsi/ultrastor.c~drivers-scsi-ultrastorc-fix-asm-snippet drivers/scsi/ultrastor.c
--- a/drivers/scsi/ultrastor.c~drivers-scsi-ultrastorc-fix-asm-snippet
+++ a/drivers/scsi/ultrastor.c
@@ -307,7 +307,7 @@ static inline int find_and_clear_bit_16(
 	"0: bsfw %1,%w0\n\t"
 	"btr %0,%1\n\t"
 	"jnc 0b"
-	: "=&r" (rv), "=m" (*field) :);
+	: "=&r" (rv), "+m" (*field) :);
 
   return rv;
 }
_

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2011-05-23 22:29 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-05-23 22:29 [patch 6/6] drivers/scsi/ultrastor.c: fix asm snippet akpm

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).