From: Christoph Hellwig <hch@infradead.org>
To: kiran.patil@intel.com, nab@linux-iscsi.org
Cc: linux-scsi@vger.kernel.org
Subject: tcm_fc comments
Date: Fri, 27 May 2011 06:24:10 -0400 [thread overview]
Message-ID: <20110527102410.GA14951@infradead.org> (raw)
- please remove all the extra -I lines in EXTRA_CLFAGs, none of them
should be needed.
- CONFIGFS_TCM_FC_DEBUG should be used directly in the code instead of
definining another symbol
- there's no need for thread_wq, you can just do a wake_up_process
on the task_struct for the thread. That also means you don't have
the races with the kthread API you currently have
- The set_user_nice in ft_thread needs a comment explaning why you
really need to mess with priorities here. I suspect you don't have
to anyway.
- There's lots of code like "if (!(acl)) {" with completley superflous
braces.
In general it would have been nice to have sent a review request to
linux-scsi, especially as most of these items have been commented on
multiple times for other target frontends before.
next reply other threads:[~2011-05-27 10:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-27 10:24 Christoph Hellwig [this message]
2011-05-27 21:24 ` tcm_fc comments Nicholas A. Bellinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110527102410.GA14951@infradead.org \
--to=hch@infradead.org \
--cc=kiran.patil@intel.com \
--cc=linux-scsi@vger.kernel.org \
--cc=nab@linux-iscsi.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox