From: Christoph Hellwig <hch@lst.de>
To: "Nicholas A. Bellinger" <nab@linux-iscsi.org>
Cc: Christoph Hellwig <hch@lst.de>,
linux-iscsi-target-dev@googlegroups.com,
target-devel <target-devel@vger.kernel.org>,
linux-scsi <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH 39/42] target: Call transport_new_cmd instead of adding to cmd queue
Date: Tue, 31 May 2011 12:22:00 +0200 [thread overview]
Message-ID: <20110531102200.GA31697@lst.de> (raw)
In-Reply-To: <1306836641.8193.185.camel@haakon2.linux-iscsi.org>
> +++ b/drivers/target/iscsi/iscsi_target.c
> @@ -1118,7 +1118,7 @@ attach_cmd:
> * the underlying transport plugin has allocated the buffer to
> * receive the Immediate Write Data into.
> */
> - transport_generic_handle_cdb(SE_CMD(cmd));
> + transport_generic_new_cmd(SE_CMD(cmd));
This is still missing the error handling, as well as the other callers
in the iscsi code. When adding the proper error handling please do it
by checking the transport_generic_new_cmd return value instead of
through transport_new_cmd_failure. With a bit more work this should
also allow killing off the SCF_SE_CMD_FAILED flag.
next prev parent reply other threads:[~2011-05-31 10:22 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1306523240-15543-1-git-send-email-agrover@redhat.com>
2011-05-27 22:15 ` [PATCH 0/42 RESEND+NEW] Target updates for May 27 Nicholas A. Bellinger
2011-05-27 22:35 ` Christoph Hellwig
2011-05-27 23:39 ` Nicholas A. Bellinger
2011-05-28 7:43 ` Christoph Hellwig
2011-05-28 19:09 ` Nicholas A. Bellinger
2011-05-29 2:23 ` Andy Grover
2011-05-30 12:56 ` Christoph Hellwig
[not found] ` <1306523240-15543-11-git-send-email-agrover@redhat.com>
2011-05-31 7:08 ` [PATCH 10/42] target: Rewrite transport_init_task_sg() Nicholas A. Bellinger
2011-05-31 21:04 ` Andy Grover
2011-05-31 21:08 ` Christoph Hellwig
2011-06-01 0:33 ` Nicholas A. Bellinger
[not found] ` <1306523240-15543-38-git-send-email-agrover@redhat.com>
2011-05-31 9:00 ` [PATCH 37/42] target/iscsi: Do not use t_mem_list anymore Nicholas A. Bellinger
[not found] ` <1306523240-15543-40-git-send-email-agrover@redhat.com>
2011-05-31 9:32 ` [PATCH 39/42] target: Call transport_new_cmd instead of adding to cmd queue Nicholas A. Bellinger
2011-05-31 9:48 ` Christoph Hellwig
2011-05-31 10:10 ` Nicholas A. Bellinger
2011-05-31 10:22 ` Christoph Hellwig [this message]
2011-05-31 11:22 ` Nicholas A. Bellinger
2011-05-31 10:17 ` Christoph Hellwig
2011-05-31 11:18 ` Nicholas A. Bellinger
2011-06-01 4:09 ` Christoph Hellwig
2011-06-04 2:33 ` Nicholas A. Bellinger
2011-06-04 14:18 ` Christoph Hellwig
[not found] ` <1306523240-15543-42-git-send-email-agrover@redhat.com>
2011-05-31 9:58 ` [PATCH 41/42] target/iscsi: remove unsolicited_data_comp completion Nicholas A. Bellinger
[not found] ` <1306523240-15543-43-git-send-email-agrover@redhat.com>
2011-05-31 10:59 ` [PATCH 42/42] target/file: Alloc iov[] off the stack Nicholas A. Bellinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110531102200.GA31697@lst.de \
--to=hch@lst.de \
--cc=linux-iscsi-target-dev@googlegroups.com \
--cc=linux-scsi@vger.kernel.org \
--cc=nab@linux-iscsi.org \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox