From: Christoph Hellwig <hch@infradead.org>
To: Roland Dreier <roland@kernel.org>
Cc: Christoph Hellwig <hch@infradead.org>,
"Nicholas A. Bellinger" <nab@linux-iscsi.org>,
linux-scsi@vger.kernel.org, target-devel@vger.kernel.org
Subject: Re: [PATCH] target: Make transport_lookup_cmd_lun() locking IRQ-safe
Date: Thu, 16 Jun 2011 08:15:40 -0400 [thread overview]
Message-ID: <20110616121540.GA20081@infradead.org> (raw)
In-Reply-To: <BANLkTin9U47ej2eR2ns7-=T-QHrRw=-t_Q@mail.gmail.com>
On Tue, Jun 14, 2011 at 08:58:57AM -0700, Roland Dreier wrote:
> Fair enough... however that seems like a much more major project,
> as eg the qla2xxx code does a fair bit from interrupt context.
Yes, just pointing out in which direction it should go eventually.
>
> Also it seems even if we are running from thread context it would
> be legitimate for a target driver to do
>
> spin_lock_irq(&internal_target_lock);
> ...
> transport_lookup_cmd_lun();
> ...
> spin_unlock_irq
>
> and so transport_lookup_cmd_lun() shouldn't be reenabling IRQs
> unconditionally.
Yes. At that point we shouldn't require any irq locking, making life
even easier.
next prev parent reply other threads:[~2011-06-16 12:15 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-14 3:44 [PATCH] target: Make transport_lookup_cmd_lun() locking IRQ-safe Roland Dreier
2011-06-14 8:12 ` Christoph Hellwig
2011-06-14 15:58 ` Roland Dreier
2011-06-16 12:15 ` Christoph Hellwig [this message]
2011-06-15 16:58 ` Nicholas A. Bellinger
2011-06-16 12:18 ` Christoph Hellwig
2011-06-15 17:06 ` Nicholas A. Bellinger
2011-06-15 17:22 ` Roland Dreier
2011-06-15 17:25 ` Nicholas A. Bellinger
2011-06-15 17:52 ` Kiran Patil
2011-06-15 19:41 ` Roland Dreier
2011-06-15 20:53 ` Kiran Patil
2011-06-15 18:53 ` Roland Dreier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110616121540.GA20081@infradead.org \
--to=hch@infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=nab@linux-iscsi.org \
--cc=roland@kernel.org \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox