RE: [PATCH 00/12] libfc, libfcoe and fcoe updates for scsi-misc

Love, Robert W
2011-06-20T23:55:46Z

>-----Original Message-----
>From: linux-scsi-owner@vger.kernel.org [mailto:linux-scsi-
>owner@vger.kernel.org] On Behalf Of Robert Love
>Sent: Monday, June 20, 2011 4:30 PM
>To: linux-scsi@vger.kernel.org
>Subject: [PATCH 00/12] libfc, libfcoe and fcoe updates for scsi-misc
>
>The following series contains target offload patches and
>a few bug fixes. The main change that this series presents
>is target mode offload support. These are the same offloads
>that the initiator uses, so there is no new hardware support.
>There is a new hook in the netdev_ops structure to setup
>a DDP context for an offloadable exchange. If ndo_fcoe_ddp_target
>is present on the netdevice the fcoe stack will make use of
>it. This interfce was merged at the v3.0 merge window, so
>all depedencies should already be complete and in-kernel.
>
>Aside from this feature there are a few fixes to tcm_fc as
>well as libfc and fcoe.
>
>All patches were tested against scsi-misc on the day of
>this posting.
>
>---
>
>Kiran Patil (8):
> tcm_fc: Fix warning in file tfc_io
> libfc: Enhancement to RPORT state machine applicable only for
>VN2VN mode
> fcoe: Unable to select the exchangeID from offload pool for
>storage targets
> fcoe: Round-robin based selection of CPU for post-processing of
>incoming commands
> fcoe: Amends previous patch, Round-robin based selection of CPU
>for post processing of incoming request for FCoE target
> libfc:Fix for exchange/seq loopup failure when FCoE stack is used
>as target and connected to windows initaitor
> tcm_fc: Fix ft_send_tm-bug and drop ft_get_lun_for_cmd usage
> tcm_fc: Fixing reference counting problem which was causing
>ft_sess to be deleted.
>
>Neerav Parikh (1):
> fcoe: Rearrange fcoe port and NPIV port cleanup
>
>Vasu Dev (1):
> libfc: post reset event on lport reset
>
>Yi Zou (2):
> libfc, tcm_fc: add ddp_targ() to libfc function template to
>supprot FCoE DDP in target mode
> fcoe: support ndo_fcoe_ddp_target() for DDP in FCoE targe
>
>
> drivers/scsi/fcoe/fcoe.c | 174 ++++++++++++++++++++++++++++++--
>-------
> drivers/scsi/libfc/fc_exch.c | 26 +++++-
> drivers/scsi/libfc/fc_lport.c | 2
> drivers/scsi/libfc/fc_rport.c | 14 +++
> drivers/target/tcm_fc/tcm_fc.h | 2
> drivers/target/tcm_fc/tfc_cmd.c | 88 +++++++++++---------
> drivers/target/tcm_fc/tfc_io.c | 2
> include/scsi/libfc.h | 8 ++
> 8 files changed, 233 insertions(+), 83 deletions(-)
>
>--

There was a comma in one of the signed off lines. When I mail patches I use stgit
and specifically 'stg --auto' which will CC anyone who has signed the patches. I do not
use the '--auto' option when I test mail myself before mailing externally so I didn't
catch this on my test mail. I guess 'stg --auto' doesn't like '<lastname>, <firstname>'
for signed-off lines. On a quick glance, I didn't see anything in SubmittingPatches
about last name comma first name being a format violation, although I have never seen
that ordering before on signed-off lines. Stgit at least doesn't like it.

I'll resend this series as 'v2'.

Sorry for the trash, //Rob