From: Christoph Hellwig <hch@infradead.org>
To: Andy Grover <agrover@redhat.com>
Cc: target-devel@vger.kernel.org, linux-scsi@vger.kernel.org
Subject: Re: [PATCH 03/20] target: Make all control CDBs scatter-gather
Date: Fri, 8 Jul 2011 15:57:55 -0400 [thread overview]
Message-ID: <20110708195755.GA12288@infradead.org> (raw)
In-Reply-To: <1310078011-15504-4-git-send-email-agrover@redhat.com>
> @@ -2972,19 +2955,6 @@ static int transport_get_sense_data(struct se_cmd *cmd)
> return -1;
> }
>
> -static int transport_allocate_resources(struct se_cmd *cmd)
> -{
> - u32 length = cmd->data_length;
> -
> - if ((cmd->se_cmd_flags & SCF_SCSI_DATA_SG_IO_CDB) ||
> - (cmd->se_cmd_flags & SCF_SCSI_CONTROL_SG_IO_CDB))
> - return transport_generic_get_mem(cmd, length);
> - else if (cmd->se_cmd_flags & SCF_SCSI_CONTROL_NONSG_IO_CDB)
> - return transport_generic_allocate_buf(cmd, length);
> - else
> - return 0;
> -}
> -
> static int
> transport_handle_reservation_conflict(struct se_cmd *cmd)
> {
> @@ -4892,7 +4854,7 @@ int transport_generic_new_cmd(struct se_cmd *cmd)
> * cmd->t_mem_list of struct se_mem->se_page
> */
> if (!(cmd->se_cmd_flags & SCF_PASSTHROUGH_SG_TO_MEM_NOALLOC)) {
> - ret = transport_allocate_resources(cmd);
> + ret = transport_generic_get_mem(cmd);
> if (ret < 0)
> return ret;
> }
Before transport_allocate_resources used to be a no-op for
SCF_SCSI_NON_DATA_CDB cdbs, which got lots with your patch. Given that
they should have a zero length your patch should be fine, but such
subtilities would be nice to be documented in the changelog.
> * REQUEST, and the additional sense code set to INVALID
> * FIELD IN PARAMETER LIST.
> */
> + transport_kunmap_first_data_page(cmd);
> return PYX_TRANSPORT_INVALID_PARAMETER_LIST;
I would have preferred to switch to goto based unwinding from the start.
But it's not a major issue, so if no one else complains I'm fine with it
beeing fixed up in a later patch.
> +EXPORT_SYMBOL(transport_kmap_first_data_page);
> +EXPORT_SYMBOL(transport_kunmap_first_data_page);
Any reason these are exported?
> --- a/include/target/target_core_base.h
> +++ b/include/target/target_core_base.h
> @@ -109,7 +109,6 @@ enum se_cmd_flags_table {
> SCF_EMULATED_TASK_SENSE = 0x00000004,
> SCF_SCSI_DATA_SG_IO_CDB = 0x00000008,
> SCF_SCSI_CONTROL_SG_IO_CDB = 0x00000010,
> - SCF_SCSI_CONTROL_NONSG_IO_CDB = 0x00000020,
> SCF_SCSI_NON_DATA_CDB = 0x00000040,
> SCF_SCSI_CDB_EXCEPTION = 0x00000080,
> SCF_SCSI_RESERVATION_CONFLICT = 0x00000100,
You should be able to kill SCF_PASSTHROUGH_CONTIG_TO_SG as well.
next prev parent reply other threads:[~2011-07-08 19:57 UTC|newest]
Thread overview: 61+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-07 22:33 [0/20] Patches from June 28 v2 Andy Grover
2011-07-07 22:33 ` [PATCH 01/20] target: Remove ifdeffed code in t_g_process_write Andy Grover
2011-07-07 22:33 ` [PATCH 02/20] target: Pass 2nd param of transport_split_cdb by value Andy Grover
2011-07-07 22:33 ` [PATCH 03/20] target: Make all control CDBs scatter-gather Andy Grover
2011-07-08 19:57 ` Christoph Hellwig [this message]
2011-07-09 0:02 ` Andy Grover
2011-07-09 0:35 ` Andy Grover
2011-07-07 22:33 ` [PATCH 04/20] target: Enforce 1 page max for control cdb buffer sizes Andy Grover
2011-07-08 19:58 ` Christoph Hellwig
2011-07-07 22:33 ` [PATCH 05/20] target: Remove direct ramdisk code Andy Grover
2011-07-08 19:59 ` Christoph Hellwig
2011-07-07 22:33 ` [PATCH 06/20] target: Eliminate usage of struct se_mem Andy Grover
2011-07-08 20:13 ` Christoph Hellwig
2011-07-09 0:38 ` Andy Grover
2011-07-07 22:33 ` [PATCH 07/20] target: Rename task_sg_num to task_sg_nents Andy Grover
2011-07-07 22:33 ` [PATCH 08/20] target: Remove custom debug macros for pr_debug. Use pr_err() Andy Grover
2011-07-07 22:33 ` [PATCH 09/20] target: Remove custom debug macros in non-iscsi fabrics Andy Grover
2011-07-07 22:33 ` [PATCH 10/20] target/iscsi: Remove iscsi_target_debug.h and usage of TRACE() & printk() Andy Grover
2011-07-07 22:33 ` [PATCH 11/20] target/iscsi: Remove SE_CMD macro Andy Grover
2011-07-07 22:33 ` [PATCH 12/20] target: Set WSNZ=1 in block limits VPD. Abort if WRITE_SAME sectors = 0 Andy Grover
2011-07-07 22:33 ` [PATCH 13/20] target: Remove transport do_se_mem_map callback Andy Grover
2011-07-07 22:33 ` [PATCH 14/20] target: When using kunmap_first_data_page, use goto-style err handling Andy Grover
2011-07-07 22:33 ` [PATCH 15/20] target: Further simplify transport_free_pages Andy Grover
2011-07-07 22:33 ` [PATCH 16/20] target: Redo task allocation return value handling Andy Grover
2011-07-07 22:33 ` [PATCH 17/20] target/core: Remove extra parentheses Andy Grover
2011-07-07 22:33 ` [PATCH 18/20] target: Extraneous paren removal in tcm_vhost and tcm_qla2xxx Andy Grover
2011-07-07 22:33 ` [PATCH 19/20] target/iscsi: Remove unneeded parens in conditional statements Andy Grover
2011-07-07 22:33 ` [PATCH 20/20] target/iscsi: Simplify two small bits Andy Grover
2011-07-09 1:18 ` [0/20] target: Patches for June 28 v3 Andy Grover
2011-07-17 19:32 ` Nicholas A. Bellinger
2011-07-09 1:18 ` [PATCH 01/20] target: Remove ifdeffed code in t_g_process_write Andy Grover
2011-07-09 1:18 ` [PATCH 02/20] target: Pass 2nd param of transport_split_cdb by value Andy Grover
2011-07-09 1:18 ` [PATCH 03/20] target: Make all control CDBs scatter-gather Andy Grover
2011-07-17 19:40 ` Nicholas A. Bellinger
2011-07-09 1:18 ` [PATCH 04/20] target: Enforce 1 page max for control cdb buffer sizes Andy Grover
2011-07-09 1:18 ` [PATCH 05/20] target: Remove direct ramdisk code Andy Grover
2011-07-09 1:18 ` [PATCH 06/20] target: Eliminate usage of struct se_mem Andy Grover
2011-07-17 19:57 ` Nicholas A. Bellinger
2011-07-18 17:16 ` Andy Grover
2011-07-18 18:44 ` Nicholas A. Bellinger
2011-07-19 4:56 ` Christoph Hellwig
2011-07-19 5:40 ` Nicholas A. Bellinger
2011-07-09 1:18 ` [PATCH 07/20] target: Rename task_sg_num to task_sg_nents Andy Grover
2011-07-09 1:18 ` [PATCH 08/20] target: Remove custom debug macros for pr_debug. Use pr_err() Andy Grover
2011-07-09 1:18 ` [PATCH 09/20] target: Remove custom debug macros in non-iscsi fabrics Andy Grover
2011-07-17 20:02 ` Nicholas A. Bellinger
2011-07-09 1:18 ` [PATCH 10/20] target/iscsi: Remove iscsi_target_debug.h and usage of TRACE() & printk() Andy Grover
2011-07-09 1:18 ` [PATCH 11/20] target/iscsi: Remove SE_CMD macro Andy Grover
2011-07-09 1:18 ` [PATCH 12/20] target: Set WSNZ=1 in block limits VPD. Abort if WRITE_SAME sectors = 0 Andy Grover
2011-07-09 1:18 ` [PATCH 13/20] target: Remove transport do_se_mem_map callback Andy Grover
2011-07-09 1:18 ` [PATCH 14/20] target: Further simplify transport_free_pages Andy Grover
2011-07-09 1:18 ` [PATCH 15/20] target: Redo task allocation return value handling Andy Grover
2011-07-09 1:18 ` [PATCH 16/20] target/core: Remove extra parentheses Andy Grover
2011-07-09 1:18 ` [PATCH 17/20] target: Extraneous paren removal in tcm_vhost and tcm_qla2xxx Andy Grover
2011-07-09 1:18 ` [PATCH 18/20] target/iscsi: Remove unneeded parens in conditional statements Andy Grover
2011-07-09 1:18 ` [PATCH 19/20] target/iscsi: Simplify two small bits Andy Grover
2011-07-09 1:18 ` [PATCH 20/20] target: change alloc_task call to take *cdb, not *cmd Andy Grover
2011-07-09 10:11 ` Christoph Hellwig
2011-07-10 22:41 ` Andy Grover
2011-07-11 15:28 ` Christoph Hellwig
2011-07-17 20:04 ` Nicholas A. Bellinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110708195755.GA12288@infradead.org \
--to=hch@infradead.org \
--cc=agrover@redhat.com \
--cc=linux-scsi@vger.kernel.org \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox