* [PATCH] hpsa: do not attempt to read from a write-only register
@ 2011-07-08 19:59 Stephen M. Cameron
2011-07-11 20:19 ` Andrew Morton
0 siblings, 1 reply; 8+ messages in thread
From: Stephen M. Cameron @ 2011-07-08 19:59 UTC (permalink / raw)
To: james.bottomley
Cc: linux-scsi, linux-kernel, stephenmcameron, thenzl, akpm, mikem
From: Stephen M. Cameron <scameron@beardog.cce.hp.com>
Most smartarrays tolerate it, but a few new ones don't.
Signed-off-by: Stephen M. Cameron <scameron@beardog.cce.hp.com>
---
drivers/scsi/hpsa.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/scsi/hpsa.h b/drivers/scsi/hpsa.h
index 6d8dcd4..7f53cea 100644
--- a/drivers/scsi/hpsa.h
+++ b/drivers/scsi/hpsa.h
@@ -214,7 +214,7 @@ static void SA5_submit_command(struct ctlr_info *h,
dev_dbg(&h->pdev->dev, "Sending %x, tag = %x\n", c->busaddr,
c->Header.Tag.lower);
writel(c->busaddr, h->vaddr + SA5_REQUEST_PORT_OFFSET);
- (void) readl(h->vaddr + SA5_REQUEST_PORT_OFFSET);
+ (void) readl(h->vaddr + SA5_SCRATCHPAD_OFFSET);
h->commands_outstanding++;
if (h->commands_outstanding > h->max_outstanding)
h->max_outstanding = h->commands_outstanding;
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH] hpsa: do not attempt to read from a write-only register
2011-07-08 19:59 [PATCH] hpsa: do not attempt to read from a write-only register Stephen M. Cameron
@ 2011-07-11 20:19 ` Andrew Morton
2011-07-11 20:51 ` scameron
0 siblings, 1 reply; 8+ messages in thread
From: Andrew Morton @ 2011-07-11 20:19 UTC (permalink / raw)
To: Stephen M. Cameron
Cc: james.bottomley, linux-scsi, linux-kernel, stephenmcameron,
thenzl, mikem
On Fri, 08 Jul 2011 14:59:26 -0500
"Stephen M. Cameron" <scameron@beardog.cce.hp.com> wrote:
> From: Stephen M. Cameron <scameron@beardog.cce.hp.com>
>
> Most smartarrays tolerate it, but a few new ones don't.
>
> Signed-off-by: Stephen M. Cameron <scameron@beardog.cce.hp.com>
> ---
> drivers/scsi/hpsa.h | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/scsi/hpsa.h b/drivers/scsi/hpsa.h
> index 6d8dcd4..7f53cea 100644
> --- a/drivers/scsi/hpsa.h
> +++ b/drivers/scsi/hpsa.h
> @@ -214,7 +214,7 @@ static void SA5_submit_command(struct ctlr_info *h,
> dev_dbg(&h->pdev->dev, "Sending %x, tag = %x\n", c->busaddr,
> c->Header.Tag.lower);
> writel(c->busaddr, h->vaddr + SA5_REQUEST_PORT_OFFSET);
> - (void) readl(h->vaddr + SA5_REQUEST_PORT_OFFSET);
> + (void) readl(h->vaddr + SA5_SCRATCHPAD_OFFSET);
> h->commands_outstanding++;
> if (h->commands_outstanding > h->max_outstanding)
> h->max_outstanding = h->commands_outstanding;
The changelog forgot to tell us the user-visible effects of the bug.
That was really really bad of it. Bad changelog. No bone for you.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] hpsa: do not attempt to read from a write-only register
2011-07-11 20:19 ` Andrew Morton
@ 2011-07-11 20:51 ` scameron
2011-07-11 21:04 ` Andrew Morton
0 siblings, 1 reply; 8+ messages in thread
From: scameron @ 2011-07-11 20:51 UTC (permalink / raw)
To: Andrew Morton
Cc: james.bottomley, linux-scsi, linux-kernel, stephenmcameron,
thenzl, mikem
On Mon, Jul 11, 2011 at 01:19:11PM -0700, Andrew Morton wrote:
> On Fri, 08 Jul 2011 14:59:26 -0500
> "Stephen M. Cameron" <scameron@beardog.cce.hp.com> wrote:
>
> > From: Stephen M. Cameron <scameron@beardog.cce.hp.com>
> >
> > Most smartarrays tolerate it, but a few new ones don't.
> >
> > Signed-off-by: Stephen M. Cameron <scameron@beardog.cce.hp.com>
> > ---
> > drivers/scsi/hpsa.h | 2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/drivers/scsi/hpsa.h b/drivers/scsi/hpsa.h
> > index 6d8dcd4..7f53cea 100644
> > --- a/drivers/scsi/hpsa.h
> > +++ b/drivers/scsi/hpsa.h
> > @@ -214,7 +214,7 @@ static void SA5_submit_command(struct ctlr_info *h,
> > dev_dbg(&h->pdev->dev, "Sending %x, tag = %x\n", c->busaddr,
> > c->Header.Tag.lower);
> > writel(c->busaddr, h->vaddr + SA5_REQUEST_PORT_OFFSET);
> > - (void) readl(h->vaddr + SA5_REQUEST_PORT_OFFSET);
> > + (void) readl(h->vaddr + SA5_SCRATCHPAD_OFFSET);
> > h->commands_outstanding++;
> > if (h->commands_outstanding > h->max_outstanding)
> > h->max_outstanding = h->commands_outstanding;
>
> The changelog forgot to tell us the user-visible effects of the bug.
> That was really really bad of it. Bad changelog. No bone for you.
Oh, sorry. When the controller doesn't tolerate the bug, the firmware
on it locks up. No interrupts are received, no commands complete. I/o
on that controller grinds to a halt.
I can resubmit if you like.
-- steve
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] hpsa: do not attempt to read from a write-only register
2011-07-11 20:51 ` scameron
@ 2011-07-11 21:04 ` Andrew Morton
2011-07-11 21:08 ` scameron
0 siblings, 1 reply; 8+ messages in thread
From: Andrew Morton @ 2011-07-11 21:04 UTC (permalink / raw)
To: scameron
Cc: james.bottomley, linux-scsi, linux-kernel, stephenmcameron,
thenzl, mikem
On Mon, 11 Jul 2011 15:51:24 -0500
scameron@beardog.cce.hp.com wrote:
> On Mon, Jul 11, 2011 at 01:19:11PM -0700, Andrew Morton wrote:
> > On Fri, 08 Jul 2011 14:59:26 -0500
> > "Stephen M. Cameron" <scameron@beardog.cce.hp.com> wrote:
> >
> > > From: Stephen M. Cameron <scameron@beardog.cce.hp.com>
> > >
> > > Most smartarrays tolerate it, but a few new ones don't.
> > >
> > > Signed-off-by: Stephen M. Cameron <scameron@beardog.cce.hp.com>
> > > ---
> > > drivers/scsi/hpsa.h | 2 +-
> > > 1 files changed, 1 insertions(+), 1 deletions(-)
> > >
> > > diff --git a/drivers/scsi/hpsa.h b/drivers/scsi/hpsa.h
> > > index 6d8dcd4..7f53cea 100644
> > > --- a/drivers/scsi/hpsa.h
> > > +++ b/drivers/scsi/hpsa.h
> > > @@ -214,7 +214,7 @@ static void SA5_submit_command(struct ctlr_info *h,
> > > dev_dbg(&h->pdev->dev, "Sending %x, tag = %x\n", c->busaddr,
> > > c->Header.Tag.lower);
> > > writel(c->busaddr, h->vaddr + SA5_REQUEST_PORT_OFFSET);
> > > - (void) readl(h->vaddr + SA5_REQUEST_PORT_OFFSET);
> > > + (void) readl(h->vaddr + SA5_SCRATCHPAD_OFFSET);
> > > h->commands_outstanding++;
> > > if (h->commands_outstanding > h->max_outstanding)
> > > h->max_outstanding = h->commands_outstanding;
> >
> > The changelog forgot to tell us the user-visible effects of the bug.
> > That was really really bad of it. Bad changelog. No bone for you.
>
> Oh, sorry. When the controller doesn't tolerate the bug, the firmware
> on it locks up. No interrupts are received, no commands complete. I/o
> on that controller grinds to a halt.
OK, that was important.
Presumably you'd like those newer controllers to work with older
kernels? In which case we should mark the patch for -stable
backporting?
I've done that to my copy and have updated the changelog.
> I can resubmit if you like.
I have two other needed-in-3.0 scsi patches. I'll send all three
Jameswards now.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] hpsa: do not attempt to read from a write-only register
2011-07-11 21:04 ` Andrew Morton
@ 2011-07-11 21:08 ` scameron
0 siblings, 0 replies; 8+ messages in thread
From: scameron @ 2011-07-11 21:08 UTC (permalink / raw)
To: Andrew Morton
Cc: james.bottomley, linux-scsi, linux-kernel, stephenmcameron,
thenzl, mikem
On Mon, Jul 11, 2011 at 02:04:50PM -0700, Andrew Morton wrote:
> On Mon, 11 Jul 2011 15:51:24 -0500
> scameron@beardog.cce.hp.com wrote:
>
> > On Mon, Jul 11, 2011 at 01:19:11PM -0700, Andrew Morton wrote:
> > > On Fri, 08 Jul 2011 14:59:26 -0500
> > > "Stephen M. Cameron" <scameron@beardog.cce.hp.com> wrote:
> > >
> > > > From: Stephen M. Cameron <scameron@beardog.cce.hp.com>
> > > >
> > > > Most smartarrays tolerate it, but a few new ones don't.
> > > >
> > > > Signed-off-by: Stephen M. Cameron <scameron@beardog.cce.hp.com>
> > > > ---
> > > > drivers/scsi/hpsa.h | 2 +-
> > > > 1 files changed, 1 insertions(+), 1 deletions(-)
> > > >
> > > > diff --git a/drivers/scsi/hpsa.h b/drivers/scsi/hpsa.h
> > > > index 6d8dcd4..7f53cea 100644
> > > > --- a/drivers/scsi/hpsa.h
> > > > +++ b/drivers/scsi/hpsa.h
> > > > @@ -214,7 +214,7 @@ static void SA5_submit_command(struct ctlr_info *h,
> > > > dev_dbg(&h->pdev->dev, "Sending %x, tag = %x\n", c->busaddr,
> > > > c->Header.Tag.lower);
> > > > writel(c->busaddr, h->vaddr + SA5_REQUEST_PORT_OFFSET);
> > > > - (void) readl(h->vaddr + SA5_REQUEST_PORT_OFFSET);
> > > > + (void) readl(h->vaddr + SA5_SCRATCHPAD_OFFSET);
> > > > h->commands_outstanding++;
> > > > if (h->commands_outstanding > h->max_outstanding)
> > > > h->max_outstanding = h->commands_outstanding;
> > >
> > > The changelog forgot to tell us the user-visible effects of the bug.
> > > That was really really bad of it. Bad changelog. No bone for you.
> >
> > Oh, sorry. When the controller doesn't tolerate the bug, the firmware
> > on it locks up. No interrupts are received, no commands complete. I/o
> > on that controller grinds to a halt.
>
> OK, that was important.
>
> Presumably you'd like those newer controllers to work with older
> kernels? In which case we should mark the patch for -stable
> backporting?
Yes.
>
> I've done that to my copy and have updated the changelog.
>
> > I can resubmit if you like.
>
> I have two other needed-in-3.0 scsi patches. I'll send all three
> Jameswards now.
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] hpsa: do not attempt to read from a write-only register
@ 2011-07-21 18:16 Stephen M. Cameron
2011-07-21 18:17 ` Stephen Cameron
2011-07-22 22:39 ` Andrew Morton
0 siblings, 2 replies; 8+ messages in thread
From: Stephen M. Cameron @ 2011-07-21 18:16 UTC (permalink / raw)
To: james.bottomley
Cc: linux-scsi, linux-kernel, stephenmcameron, thenzl, akpm, mikem
From: Stephen M. Cameron <scameron@beardog.cce.hp.com>
Most smartarrays tolerate it, but a few new ones don't.
Without this change some newer Smart Arrays will lock up
and i/o will grind to a halt.
Signed-off-by: Stephen M. Cameron <scameron@beardog.cce.hp.com>
---
drivers/scsi/hpsa.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/scsi/hpsa.h b/drivers/scsi/hpsa.h
index 6d8dcd4..7f53cea 100644
--- a/drivers/scsi/hpsa.h
+++ b/drivers/scsi/hpsa.h
@@ -214,7 +214,7 @@ static void SA5_submit_command(struct ctlr_info *h,
dev_dbg(&h->pdev->dev, "Sending %x, tag = %x\n", c->busaddr,
c->Header.Tag.lower);
writel(c->busaddr, h->vaddr + SA5_REQUEST_PORT_OFFSET);
- (void) readl(h->vaddr + SA5_REQUEST_PORT_OFFSET);
+ (void) readl(h->vaddr + SA5_SCRATCHPAD_OFFSET);
h->commands_outstanding++;
if (h->commands_outstanding > h->max_outstanding)
h->max_outstanding = h->commands_outstanding;
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH] hpsa: do not attempt to read from a write-only register
2011-07-21 18:16 Stephen M. Cameron
@ 2011-07-21 18:17 ` Stephen Cameron
2011-07-22 22:39 ` Andrew Morton
1 sibling, 0 replies; 8+ messages in thread
From: Stephen Cameron @ 2011-07-21 18:17 UTC (permalink / raw)
To: Stephen M. Cameron
Cc: james.bottomley, linux-scsi, linux-kernel, thenzl, akpm, mikem
On Thu, Jul 21, 2011 at 1:16 PM, Stephen M. Cameron
<scameron@beardog.cce.hp.com> wrote:
> From: Stephen M. Cameron <scameron@beardog.cce.hp.com>
>
> Most smartarrays tolerate it, but a few new ones don't.
> Without this change some newer Smart Arrays will lock up
> and i/o will grind to a halt.
Noticed this wasn't in Linus's git tree yet, so resent it.
-- steve
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] hpsa: do not attempt to read from a write-only register
2011-07-21 18:16 Stephen M. Cameron
2011-07-21 18:17 ` Stephen Cameron
@ 2011-07-22 22:39 ` Andrew Morton
1 sibling, 0 replies; 8+ messages in thread
From: Andrew Morton @ 2011-07-22 22:39 UTC (permalink / raw)
To: Stephen M. Cameron
Cc: linux-scsi, linux-kernel, stable, james.bottomley,
stephenmcameron, thenzl, mikem
On Thu, 21 Jul 2011 13:16:05 -0500
"Stephen M. Cameron" <scameron@beardog.cce.hp.com> wrote:
> From: Stephen M. Cameron <scameron@beardog.cce.hp.com>
>
> Most smartarrays tolerate it, but a few new ones don't.
> Without this change some newer Smart Arrays will lock up
> and i/o will grind to a halt.
>
> Signed-off-by: Stephen M. Cameron <scameron@beardog.cce.hp.com>
Cc: <stable@kernel.org>?
> diff --git a/drivers/scsi/hpsa.h b/drivers/scsi/hpsa.h
> index 6d8dcd4..7f53cea 100644
> --- a/drivers/scsi/hpsa.h
> +++ b/drivers/scsi/hpsa.h
> @@ -214,7 +214,7 @@ static void SA5_submit_command(struct ctlr_info *h,
> dev_dbg(&h->pdev->dev, "Sending %x, tag = %x\n", c->busaddr,
> c->Header.Tag.lower);
> writel(c->busaddr, h->vaddr + SA5_REQUEST_PORT_OFFSET);
> - (void) readl(h->vaddr + SA5_REQUEST_PORT_OFFSET);
> + (void) readl(h->vaddr + SA5_SCRATCHPAD_OFFSET);
> h->commands_outstanding++;
> if (h->commands_outstanding > h->max_outstanding)
> h->max_outstanding = h->commands_outstanding;
_______________________________________________
stable mailing list
stable@linux.kernel.org
http://linux.kernel.org/mailman/listinfo/stable
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2011-07-22 22:39 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-07-08 19:59 [PATCH] hpsa: do not attempt to read from a write-only register Stephen M. Cameron
2011-07-11 20:19 ` Andrew Morton
2011-07-11 20:51 ` scameron
2011-07-11 21:04 ` Andrew Morton
2011-07-11 21:08 ` scameron
-- strict thread matches above, loose matches on Subject: below --
2011-07-21 18:16 Stephen M. Cameron
2011-07-21 18:17 ` Stephen Cameron
2011-07-22 22:39 ` Andrew Morton
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox