public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH 0/3] qla2xxx: Updates for scsi misc 3.0.
@ 2011-07-14 17:07 giridhar.malavali
  2011-07-14 17:07 ` [PATCH 1/3] qla2xxx: Basic infrastructure for dynamic logging giridhar.malavali
                   ` (3 more replies)
  0 siblings, 4 replies; 9+ messages in thread
From: giridhar.malavali @ 2011-07-14 17:07 UTC (permalink / raw)
  To: jbottomley; +Cc: giridhar.malavali, chad.dupuis, andrew.vasquez, linux-scsi

From: Giridhar Malavali <giridhar.malavali@qlogic.com>

James,

Please apply these patches.

The patch 1/3 has couple of warnings w.r.t KERN_facility level with printk.

WARNING: printk() should include KERN_ facility level

Using KERN facility in printk will print each buffer information in new line causing
unreadable log messages.

Here is an example

With KERN facility
Mar 23 10:05:37 linux-dcaw kernel: qla2xxx [0000:18:00.6]4:1102:
Mar 23 10:05:37 linux-dcaw kernel: 42
Mar 23 10:05:37 linux-dcaw kernel:
Mar 23 10:05:37 linux-dcaw kernel: 00

Without KERN facility
Mar 21 13:07:35 linux-dcaw kernel: qla2xxx [0000:18:00.7]37:1102: 48  00  00  00  5b  f2  00

Hope this should be fine since this is not an error.

-- Giridhar
Saurav Kashyap (3):
  qla2xxx: Basic infrastructure for dynamic logging.
  qla2xxx: Code changes to support new dynamic logging infrastructure.
  qla2xxx: Cleanup of previous infrastructure.

 drivers/scsi/qla2xxx/qla_attr.c   |  183 ++++---
 drivers/scsi/qla2xxx/qla_bsg.c    |  441 ++++++++-------
 drivers/scsi/qla2xxx/qla_dbg.c    |  396 ++++++++++----
 drivers/scsi/qla2xxx/qla_dbg.h    |  187 ++-----
 drivers/scsi/qla2xxx/qla_dfs.c    |   16 +-
 drivers/scsi/qla2xxx/qla_gbl.h    |    8 +-
 drivers/scsi/qla2xxx/qla_gs.c     |  371 +++++++-------
 drivers/scsi/qla2xxx/qla_init.c   |  856 +++++++++++++++--------------
 drivers/scsi/qla2xxx/qla_inline.h |    8 +-
 drivers/scsi/qla2xxx/qla_iocb.c   |  120 ++---
 drivers/scsi/qla2xxx/qla_isr.c    |  663 +++++++++++------------
 drivers/scsi/qla2xxx/qla_mbx.c    | 1091 ++++++++++++++++++-------------------
 drivers/scsi/qla2xxx/qla_mid.c    |  160 ++++--
 drivers/scsi/qla2xxx/qla_nx.c     |  556 +++++++++++--------
 drivers/scsi/qla2xxx/qla_os.c     |  747 ++++++++++++++++---------
 drivers/scsi/qla2xxx/qla_sup.c    |  275 ++++++----
 16 files changed, 3258 insertions(+), 2820 deletions(-)


^ permalink raw reply	[flat|nested] 9+ messages in thread
* [PATCH 0/3] qla2xxx: Updates for scsi misc 3.0.
@ 2011-07-14  6:30 giridhar.malavali
  0 siblings, 0 replies; 9+ messages in thread
From: giridhar.malavali @ 2011-07-14  6:30 UTC (permalink / raw)
  To: James.Bottomley
  Cc: giridhar.malavali, chad.dupuis, andrew.vasquez, linux-scsi

From: Giridhar Malavali <giridhar.malavali@qlogic.com>

James,

Please apply these patches.

The patch 1/3 has couple of warnings w.r.t KERN_facility level with printk.

WARNING: printk() should include KERN_ facility level

Using KERN facility in printk will print each buffer information in new line causing
unreadable log messages.

Here is an example

With KERN facility
Mar 23 10:05:37 linux-dcaw kernel: qla2xxx [0000:18:00.6]4:1102:
Mar 23 10:05:37 linux-dcaw kernel: 42
Mar 23 10:05:37 linux-dcaw kernel:
Mar 23 10:05:37 linux-dcaw kernel: 00

Without KERN facility
Mar 21 13:07:35 linux-dcaw kernel: qla2xxx [0000:18:00.7]37:1102: 48  00  00  00  5b  f2  00

Hope this should be fine since this is not an error.

-- Giridhar
Saurav Kashyap (3):
  qla2xxx: Basic infrastructure for dynamic logging.
  qla2xxx: Code changes to support new dynamic logging infrastructure.
  qla2xxx: Cleanup of previous infrastructure.

 drivers/scsi/qla2xxx/qla_attr.c   |  183 ++++---
 drivers/scsi/qla2xxx/qla_bsg.c    |  441 ++++++++-------
 drivers/scsi/qla2xxx/qla_dbg.c    |  396 ++++++++++----
 drivers/scsi/qla2xxx/qla_dbg.h    |  187 ++-----
 drivers/scsi/qla2xxx/qla_dfs.c    |   16 +-
 drivers/scsi/qla2xxx/qla_gbl.h    |    8 +-
 drivers/scsi/qla2xxx/qla_gs.c     |  371 +++++++-------
 drivers/scsi/qla2xxx/qla_init.c   |  856 +++++++++++++++--------------
 drivers/scsi/qla2xxx/qla_inline.h |    8 +-
 drivers/scsi/qla2xxx/qla_iocb.c   |  120 ++---
 drivers/scsi/qla2xxx/qla_isr.c    |  663 +++++++++++------------
 drivers/scsi/qla2xxx/qla_mbx.c    | 1091 ++++++++++++++++++-------------------
 drivers/scsi/qla2xxx/qla_mid.c    |  160 ++++--
 drivers/scsi/qla2xxx/qla_nx.c     |  556 +++++++++++--------
 drivers/scsi/qla2xxx/qla_os.c     |  747 ++++++++++++++++---------
 drivers/scsi/qla2xxx/qla_sup.c    |  275 ++++++----
 16 files changed, 3258 insertions(+), 2820 deletions(-)


^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2011-07-14 19:14 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-07-14 17:07 [PATCH 0/3] qla2xxx: Updates for scsi misc 3.0 giridhar.malavali
2011-07-14 17:07 ` [PATCH 1/3] qla2xxx: Basic infrastructure for dynamic logging giridhar.malavali
2011-07-14 17:07 ` [PATCH 3/3] qla2xxx: Cleanup of previous infrastructure giridhar.malavali
2011-07-14 17:29 ` [PATCH 0/3] qla2xxx: Updates for scsi misc 3.0 James Bottomley
2011-07-14 17:36   ` Giridhar Malavali
2011-07-14 17:37     ` James Bottomley
2011-07-14 19:13       ` Giridhar Malavali
2011-07-14 17:47 ` Matthew Wilcox
  -- strict thread matches above, loose matches on Subject: below --
2011-07-14  6:30 giridhar.malavali

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox