From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andi Kleen Subject: Re: Linux 3.0 oopses when pulling a USB CDROM Date: Mon, 18 Jul 2011 20:00:07 +0200 Message-ID: <20110718180007.GE8006@one.firstfloor.org> References: <20110702181146.GM23059@one.firstfloor.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Dan Williams Cc: Alan Stern , Andi Kleen , axboe@kernel.dk, James Bottomley , Dave Jones , SCSI development list , Kernel development list , "Rafael J. Wysocki" , USB list List-Id: linux-scsi@vger.kernel.org > This patch seems to resolve the block/scsi null-ptr de-references in > our libsas/isci environment, we have yet to try James' alternative > [1]. Do we potentially need both? > > Commit 86cbfb56 moved scsi_free_queue to __scsi_remove_device() but it > seems only the "sdev->request_queue->queuedata = NULL" needed to be > moved? > > The conversation appeared to be awaiting test results... Alan's patch worked for me too. -Andi -- ak@linux.intel.com -- Speaking for myself only.