public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
From: Dan Williams <dan.j.williams@intel.com>
To: jaxboe@fusionio.com
Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org
Subject: [RFC PATCH 0/2] block: rq_affinity performance fixes
Date: Fri, 22 Jul 2011 13:59:33 -0700	[thread overview]
Message-ID: <20110722205736.17420.41366.stgit@localhost6.localdomain6> (raw)

Jens,

Per the "rq_affinity doesn't seem to work?" thread [1].  We found that the
default cpu steering that rq_affinity performs is insufficient to keep up with
some completion loads.

Dave collected the following relative iops measures:
pre-patches  rq_affinity=0: 1x
pre-patches  rq_affinity=1: 1x
post-patches rq_affinity=1: 1.08x
post-patches rq_affinity=2: 1.35x

The "adaptive rq_affinity" patch is more of a discussion point than a
real fix.  However, it shows that even something straightforward and
seemingly aggressive does not really come close to the performance of
just turning cpu grouping off altogether.  The "strict rq_affinity"
patch follows the "nomerges" interface precedent of setting 2 to
indicate "I really mean it".

So, at a minimum consider taking patch 1, and we can leave the search
for a better adaptive algorithm as future work.

[1]: http://marc.info/?l=linux-kernel&m=131049742925413&w=4

---

Dan Williams (2):
      block: strict rq_affinity
      block: adaptive rq_affinity

 Documentation/block/queue-sysfs.txt |   10 +++++++---
 block/blk-core.c                    |    6 ++----
 block/blk-softirq.c                 |   23 ++++++++++++++++++-----
 block/blk-sysfs.c                   |   13 +++++++++----
 include/linux/blkdev.h              |    3 ++-
 5 files changed, 38 insertions(+), 17 deletions(-)

             reply	other threads:[~2011-07-22 20:59 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-22 20:59 Dan Williams [this message]
2011-07-22 20:59 ` [RFC PATCH 1/2] block: strict rq_affinity Dan Williams
2011-07-23  1:46   ` Christoph Hellwig
2011-07-23 18:38     ` Jens Axboe
2011-07-23 18:41   ` Jens Axboe
2011-07-25  1:14     ` Shaohua Li
2011-07-25  8:21       ` Jens Axboe
2011-07-22 20:59 ` [RFC PATCH 2/2] block: adaptive rq_affinity Dan Williams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110722205736.17420.41366.stgit@localhost6.localdomain6 \
    --to=dan.j.williams@intel.com \
    --cc=jaxboe@fusionio.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox