From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ingo Molnar Subject: Re: [PATCH] iommu: parse pci device scope even only intr remap is defined Date: Mon, 25 Jul 2011 09:19:41 +0200 Message-ID: <20110725071941.GA22518@elte.hu> References: <20110721085636.GJ9216@elte.hu> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-pci-owner@vger.kernel.org To: Yinghai Lu Cc: Suresh Siddha , Vinod Koul , Dan Williams , Joerg Roedel , "H. Peter Anvin" , Andrew Vasquez , linux scsi dev , linux pci , "hpa@linux.intel.com" , Avik Shau , Giridhar Malavali List-Id: linux-scsi@vger.kernel.org * Yinghai Lu wrote: > > This looks very messy. > > > > CONFIG_DMAR has no clear meaning. The DMAR table parsing > > functionality is intermixed with the DMAR feature itself. The > > kernel code is littered with a couple of dozen CONFIG_DMAR > > #ifdefs with no clear structure to the initialization and to the > > separation of functionality. > > CONFIG_DMAR is actually DMA_REMAP instead DMAR table. > > or Do you prefer to clean them up further with following depency? > > CONFIG_DMAR_TBL for DMAR table > CONFIG_DMA_REMAP for DMA remapping > CONFIG_INTR_REMAP for Interrupt remapping > and XXX_REMAP will select DMAR_TBL 'DMAR', 'TBL' and 'INTR' are all misnomers! CONFIG_DMA_REMAP_TABLE CONFIG_DMA_REMAP CONFIG_IRQ_REMAP That way we'd get the 'DMAR tables' via CONFIG_DMA_REMAP_TABLE - on top of which enabling CONFIG_DMA_REMAP and CONFIG_IRQ_REMAP would enable and handle various hw remapping features. (Does anyone else have better/other code structure suggestions?) But yes, we should first do this rename/cleanup to clarify what it all means, then fix whatever config-combos don't work perfectly yet. Thanks, Ingo