From: Robert Love <robert.w.love@intel.com>
To: linux-scsi@vger.kernel.org
Cc: Hillf Danton <dhillf@gmail.com>
Subject: [PATCH 02/10] libfc: use FC_MAX_ERROR_CNT
Date: Wed, 27 Jul 2011 15:10:28 -0700 [thread overview]
Message-ID: <20110727221028.23675.44066.stgit@localhost6.localdomain6> (raw)
In-Reply-To: <20110727221018.23675.3551.stgit@localhost6.localdomain6>
From: Hillf Danton <dhillf@gmail.com>
Though defined, FC_MAX_ERROR_CNT is not used. It is used now for CRC error in
the path of receiving FCP frame.
Signed-off-by: Hillf Danton <dhillf@gmail.com>
Signed-off-by: Robert Love <robert.w.love@intel.com>
---
drivers/scsi/libfc/fc_fcp.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/scsi/libfc/fc_fcp.c b/drivers/scsi/libfc/fc_fcp.c
index 9cd2149..41f7070 100644
--- a/drivers/scsi/libfc/fc_fcp.c
+++ b/drivers/scsi/libfc/fc_fcp.c
@@ -498,7 +498,7 @@ crc_err:
stats = per_cpu_ptr(lport->dev_stats, get_cpu());
stats->ErrorFrames++;
/* per cpu count, not total count, but OK for limit */
- if (stats->InvalidCRCCount++ < 5)
+ if (stats->InvalidCRCCount++ < FC_MAX_ERROR_CNT)
printk(KERN_WARNING "libfc: CRC error on data "
"frame for port (%6.6x)\n",
lport->port_id);
next prev parent reply other threads:[~2011-07-27 22:10 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-27 22:10 [PATCH 00/10] libfc, libfcoe and fcoe updates for scsi-misc Robert Love
2011-07-27 22:10 ` [PATCH 01/10] fcoe: remove unused ptype field in fcoe_rcv_info Robert Love
2011-07-27 22:10 ` Robert Love [this message]
2011-07-27 22:10 ` [PATCH 03/10] libfc: release exchg cache Robert Love
2011-07-27 22:10 ` [PATCH 04/10] libfc, fcoe: ignore rx frame with wrong xid info Robert Love
2011-07-27 22:10 ` [PATCH 05/10] libfc: two minor changes in comments Robert Love
2011-07-27 22:10 ` [PATCH 06/10] libfc: cleanup sending SRR request Robert Love
2011-07-27 22:10 ` [PATCH 07/10] libfc: Remove the reference to FCP packet from scsi_cmnd in case of error Robert Love
2011-07-27 22:11 ` [PATCH 08/10] libfc: fix warn on in lport retry Robert Love
2011-07-27 22:11 ` [PATCH 09/10] fcoe: add fip retry to avoid missing critical keep alive Robert Love
2011-07-27 22:11 ` [PATCH 10/10] fcoe: cleanup cpu selection for incoming requests Robert Love
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110727221028.23675.44066.stgit@localhost6.localdomain6 \
--to=robert.w.love@intel.com \
--cc=dhillf@gmail.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox