From: Robert Love <robert.w.love@intel.com>
To: linux-scsi@vger.kernel.org
Cc: Hillf Danton <dhillf@gmail.com>, Vasu Dev <vasu.dev@intel.com>
Subject: [PATCH 03/10] libfc: release exchg cache
Date: Wed, 27 Jul 2011 15:10:34 -0700 [thread overview]
Message-ID: <20110727221034.23675.81378.stgit@localhost6.localdomain6> (raw)
In-Reply-To: <20110727221018.23675.3551.stgit@localhost6.localdomain6>
From: Hillf Danton <dhillf@gmail.com>
If fail to create workqueue, the newly created cache for exchg has to be
released.
Signed-off-by: Hillf Danton <dhillf@gmail.com>
Reviewed-by: Vasu Dev <vasu.dev@intel.com>
Signed-off-by: Robert Love <robert.w.love@intel.com>
---
drivers/scsi/libfc/fc_exch.c | 5 ++++-
1 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/drivers/scsi/libfc/fc_exch.c b/drivers/scsi/libfc/fc_exch.c
index f5a0665..7baf223 100644
--- a/drivers/scsi/libfc/fc_exch.c
+++ b/drivers/scsi/libfc/fc_exch.c
@@ -2465,8 +2465,11 @@ int fc_setup_exch_mgr(void)
fc_exch_workqueue = create_singlethread_workqueue("fc_exch_workqueue");
if (!fc_exch_workqueue)
- return -ENOMEM;
+ goto err;
return 0;
+err:
+ kmem_cache_destroy(fc_em_cachep);
+ return -ENOMEM;
}
/**
next prev parent reply other threads:[~2011-07-27 22:10 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-27 22:10 [PATCH 00/10] libfc, libfcoe and fcoe updates for scsi-misc Robert Love
2011-07-27 22:10 ` [PATCH 01/10] fcoe: remove unused ptype field in fcoe_rcv_info Robert Love
2011-07-27 22:10 ` [PATCH 02/10] libfc: use FC_MAX_ERROR_CNT Robert Love
2011-07-27 22:10 ` Robert Love [this message]
2011-07-27 22:10 ` [PATCH 04/10] libfc, fcoe: ignore rx frame with wrong xid info Robert Love
2011-07-27 22:10 ` [PATCH 05/10] libfc: two minor changes in comments Robert Love
2011-07-27 22:10 ` [PATCH 06/10] libfc: cleanup sending SRR request Robert Love
2011-07-27 22:10 ` [PATCH 07/10] libfc: Remove the reference to FCP packet from scsi_cmnd in case of error Robert Love
2011-07-27 22:11 ` [PATCH 08/10] libfc: fix warn on in lport retry Robert Love
2011-07-27 22:11 ` [PATCH 09/10] fcoe: add fip retry to avoid missing critical keep alive Robert Love
2011-07-27 22:11 ` [PATCH 10/10] fcoe: cleanup cpu selection for incoming requests Robert Love
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110727221034.23675.81378.stgit@localhost6.localdomain6 \
--to=robert.w.love@intel.com \
--cc=dhillf@gmail.com \
--cc=linux-scsi@vger.kernel.org \
--cc=vasu.dev@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox