* [SCSI] mpt2sas: _scsih_smart_predicted_fault uses GFP_KERNEL in interrupt context
@ 2011-07-31 9:29 Anton Blanchard
2011-11-07 11:05 ` Anton Blanchard
0 siblings, 1 reply; 3+ messages in thread
From: Anton Blanchard @ 2011-07-31 9:29 UTC (permalink / raw)
To: kashyap.desai, eric.moore, JBottomley; +Cc: linux-scsi
_scsih_smart_predicted_fault is called in an interrupt and therefore
must allocate memory using GFP_ATOMIC.
Signed-off-by: Anton Blanchard <anton@samba.org>
Cc: <stable@kernel.org>
---
Index: linux-2.6/drivers/scsi/mpt2sas/mpt2sas_scsih.c
===================================================================
--- linux-2.6.orig/drivers/scsi/mpt2sas/mpt2sas_scsih.c 2011-07-31 09:58:36.000000000 +1000
+++ linux-2.6/drivers/scsi/mpt2sas/mpt2sas_scsih.c 2011-07-31 17:31:53.000000000 +1000
@@ -4210,7 +4210,7 @@ _scsih_smart_predicted_fault(struct MPT2
/* insert into event log */
sz = offsetof(Mpi2EventNotificationReply_t, EventData) +
sizeof(Mpi2EventDataSasDeviceStatusChange_t);
- event_reply = kzalloc(sz, GFP_KERNEL);
+ event_reply = kzalloc(sz, GFP_ATOMIC);
if (!event_reply) {
printk(MPT2SAS_ERR_FMT "failure at %s:%d/%s()!\n",
ioc->name, __FILE__, __LINE__, __func__);
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [SCSI] mpt2sas: _scsih_smart_predicted_fault uses GFP_KERNEL in interrupt context
2011-07-31 9:29 [SCSI] mpt2sas: _scsih_smart_predicted_fault uses GFP_KERNEL in interrupt context Anton Blanchard
@ 2011-11-07 11:05 ` Anton Blanchard
2011-11-10 4:17 ` Nandigama, Nagalakshmi
0 siblings, 1 reply; 3+ messages in thread
From: Anton Blanchard @ 2011-11-07 11:05 UTC (permalink / raw)
To: kashyap.desai; +Cc: eric.moore, JBottomley, linux-scsi
Hi Kashyap,
On Sun, 31 Jul 2011 19:29:09 +1000
Anton Blanchard <anton@samba.org> wrote:
>
> _scsih_smart_predicted_fault is called in an interrupt and therefore
> must allocate memory using GFP_ATOMIC.
Just noticed this hasn't made it upstream, any chance you could review
it for merging?
Anton
--
_scsih_smart_predicted_fault is called in an interrupt and therefore
must allocate memory using GFP_ATOMIC.
Signed-off-by: Anton Blanchard <anton@samba.org>
Cc: <stable@kernel.org>
---
Index: linux-work/drivers/scsi/mpt2sas/mpt2sas_scsih.c
===================================================================
--- linux-work.orig/drivers/scsi/mpt2sas/mpt2sas_scsih.c 2011-11-07 22:03:33.728865287 +1100
+++ linux-work/drivers/scsi/mpt2sas/mpt2sas_scsih.c 2011-11-07 22:03:39.724972491 +1100
@@ -4330,7 +4330,7 @@ _scsih_smart_predicted_fault(struct MPT2
/* insert into event log */
sz = offsetof(Mpi2EventNotificationReply_t, EventData) +
sizeof(Mpi2EventDataSasDeviceStatusChange_t);
- event_reply = kzalloc(sz, GFP_KERNEL);
+ event_reply = kzalloc(sz, GFP_ATOMIC);
if (!event_reply) {
printk(MPT2SAS_ERR_FMT "failure at %s:%d/%s()!\n",
ioc->name, __FILE__, __LINE__, __func__);
^ permalink raw reply [flat|nested] 3+ messages in thread* RE: [SCSI] mpt2sas: _scsih_smart_predicted_fault uses GFP_KERNEL in interrupt context
2011-11-07 11:05 ` Anton Blanchard
@ 2011-11-10 4:17 ` Nandigama, Nagalakshmi
0 siblings, 0 replies; 3+ messages in thread
From: Nandigama, Nagalakshmi @ 2011-11-10 4:17 UTC (permalink / raw)
To: Anton Blanchard; +Cc: James Bottomley, linux-scsi@vger.kernel.org
The patch seem to be fine. Please consider this patch as an Acked by me
Regards,
Nagalakshmi
-----Original Message-----
From: Anton Blanchard [mailto:anton@samba.org]
Sent: Monday, November 07, 2011 4:35 PM
To: Desai, Kashyap
Cc: Moore, Eric; JBottomley@parallels.com; linux-scsi@vger.kernel.org
Subject: Re: [SCSI] mpt2sas: _scsih_smart_predicted_fault uses GFP_KERNEL in interrupt context
Hi Kashyap,
On Sun, 31 Jul 2011 19:29:09 +1000
Anton Blanchard <anton@samba.org> wrote:
>
> _scsih_smart_predicted_fault is called in an interrupt and therefore
> must allocate memory using GFP_ATOMIC.
Just noticed this hasn't made it upstream, any chance you could review
it for merging?
Anton
--
_scsih_smart_predicted_fault is called in an interrupt and therefore
must allocate memory using GFP_ATOMIC.
Signed-off-by: Anton Blanchard <anton@samba.org>
Cc: <stable@kernel.org>
---
Index: linux-work/drivers/scsi/mpt2sas/mpt2sas_scsih.c
===================================================================
--- linux-work.orig/drivers/scsi/mpt2sas/mpt2sas_scsih.c 2011-11-07 22:03:33.728865287 +1100
+++ linux-work/drivers/scsi/mpt2sas/mpt2sas_scsih.c 2011-11-07 22:03:39.724972491 +1100
@@ -4330,7 +4330,7 @@ _scsih_smart_predicted_fault(struct MPT2
/* insert into event log */
sz = offsetof(Mpi2EventNotificationReply_t, EventData) +
sizeof(Mpi2EventDataSasDeviceStatusChange_t);
- event_reply = kzalloc(sz, GFP_KERNEL);
+ event_reply = kzalloc(sz, GFP_ATOMIC);
if (!event_reply) {
printk(MPT2SAS_ERR_FMT "failure at %s:%d/%s()!\n",
ioc->name, __FILE__, __LINE__, __func__);
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-11-10 4:17 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-07-31 9:29 [SCSI] mpt2sas: _scsih_smart_predicted_fault uses GFP_KERNEL in interrupt context Anton Blanchard
2011-11-07 11:05 ` Anton Blanchard
2011-11-10 4:17 ` Nandigama, Nagalakshmi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox