* [patch] iscsi-target: remove duplicate return
@ 2011-08-06 14:29 Dan Carpenter
2011-08-08 20:58 ` Nicholas A. Bellinger
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2011-08-06 14:29 UTC (permalink / raw)
To: Nicholas A. Bellinger
Cc: Andy Grover, Dan Carpenter, Roland Dreier, Christoph Hellwig,
open list:TARGET SUBSYSTEM, open list:TARGET SUBSYSTEM,
kernel-janitors
We returned on the line before already.
Signed-off-by: Dan Carpenter <error27@gmail.com>
diff --git a/drivers/target/iscsi/iscsi_target.c b/drivers/target/iscsi/iscsi_target.c
index c24fb10..6a4ea29 100644
--- a/drivers/target/iscsi/iscsi_target.c
+++ b/drivers/target/iscsi/iscsi_target.c
@@ -2243,7 +2243,6 @@ static int iscsit_handle_snack(
case 0:
return iscsit_handle_recovery_datain_or_r2t(conn, buf,
hdr->itt, hdr->ttt, hdr->begrun, hdr->runlength);
- return 0;
case ISCSI_FLAG_SNACK_TYPE_STATUS:
return iscsit_handle_status_snack(conn, hdr->itt, hdr->ttt,
hdr->begrun, hdr->runlength);
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [patch] iscsi-target: remove duplicate return
2011-08-06 14:29 [patch] iscsi-target: remove duplicate return Dan Carpenter
@ 2011-08-08 20:58 ` Nicholas A. Bellinger
0 siblings, 0 replies; 2+ messages in thread
From: Nicholas A. Bellinger @ 2011-08-08 20:58 UTC (permalink / raw)
To: Dan Carpenter
Cc: open list:TARGET SUBSYSTEM, open list:TARGET SUBSYSTEM,
kernel-janitors
On Sat, 2011-08-06 at 07:29 -0700, Dan Carpenter wrote:
> We returned on the line before already.
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
>
> diff --git a/drivers/target/iscsi/iscsi_target.c b/drivers/target/iscsi/iscsi_target.c
> index c24fb10..6a4ea29 100644
> --- a/drivers/target/iscsi/iscsi_target.c
> +++ b/drivers/target/iscsi/iscsi_target.c
> @@ -2243,7 +2243,6 @@ static int iscsit_handle_snack(
> case 0:
> return iscsit_handle_recovery_datain_or_r2t(conn, buf,
> hdr->itt, hdr->ttt, hdr->begrun, hdr->runlength);
> - return 0;
> case ISCSI_FLAG_SNACK_TYPE_STATUS:
> return iscsit_handle_status_snack(conn, hdr->itt, hdr->ttt,
> hdr->begrun, hdr->runlength);
> --
Thanks Dan, committed as 69b0ec3c38
--nab
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-08-08 21:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-08-06 14:29 [patch] iscsi-target: remove duplicate return Dan Carpenter
2011-08-08 20:58 ` Nicholas A. Bellinger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox