From: Dan Carpenter <error27@gmail.com>
To: "Nicholas A. Bellinger" <nab@linux-iscsi.org>
Cc: Andy Grover <agrover@redhat.com>,
Roland Dreier <roland@kernel.org>, Christoph Hellwig <hch@lst.de>,
"open list:TARGET SUBSYSTEM" <linux-scsi@vger.kernel.org>,
"open list:TARGET SUBSYSTEM" <target-devel@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: [patch] iscsi-target: forever loop in iscsit_attach_ooo_cmdsn()
Date: Sat, 6 Aug 2011 07:32:06 -0700 [thread overview]
Message-ID: <20110806143206.GF10373@mwanda> (raw)
I was looking through the code for something unrelated and noticed
what looks like a forever loop here.
Signed-off-by: Dan Carpenter <error27@gmail.com>
---
I am not familiar with the subsystem and haven't tested this, so
please review carefully.
diff --git a/drivers/target/iscsi/iscsi_target_erl1.c b/drivers/target/iscsi/iscsi_target_erl1.c
index 9806507..c4c68da 100644
--- a/drivers/target/iscsi/iscsi_target_erl1.c
+++ b/drivers/target/iscsi/iscsi_target_erl1.c
@@ -834,7 +834,7 @@ static int iscsit_attach_ooo_cmdsn(
*/
list_for_each_entry(ooo_tmp, &sess->sess_ooo_cmdsn_list,
ooo_list) {
- while (ooo_tmp->cmdsn < ooo_cmdsn->cmdsn)
+ if (ooo_tmp->cmdsn < ooo_cmdsn->cmdsn)
continue;
list_add(&ooo_cmdsn->ooo_list,
next reply other threads:[~2011-08-06 14:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-06 14:32 Dan Carpenter [this message]
2011-08-08 21:07 ` [patch] iscsi-target: forever loop in iscsit_attach_ooo_cmdsn() Nicholas A. Bellinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110806143206.GF10373@mwanda \
--to=error27@gmail.com \
--cc=agrover@redhat.com \
--cc=hch@lst.de \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=nab@linux-iscsi.org \
--cc=roland@kernel.org \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox