From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Subject: [patch] iscsi-target: forever loop in iscsit_attach_ooo_cmdsn() Date: Sat, 6 Aug 2011 07:32:06 -0700 Message-ID: <20110806143206.GF10373@mwanda> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail-fx0-f46.google.com ([209.85.161.46]:64344 "EHLO mail-fx0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751073Ab1HFOcG (ORCPT ); Sat, 6 Aug 2011 10:32:06 -0400 Content-Disposition: inline Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: "Nicholas A. Bellinger" Cc: Andy Grover , Roland Dreier , Christoph Hellwig , "open list:TARGET SUBSYSTEM" , "open list:TARGET SUBSYSTEM" , kernel-janitors@vger.kernel.org I was looking through the code for something unrelated and noticed what looks like a forever loop here. Signed-off-by: Dan Carpenter --- I am not familiar with the subsystem and haven't tested this, so please review carefully. diff --git a/drivers/target/iscsi/iscsi_target_erl1.c b/drivers/target/iscsi/iscsi_target_erl1.c index 9806507..c4c68da 100644 --- a/drivers/target/iscsi/iscsi_target_erl1.c +++ b/drivers/target/iscsi/iscsi_target_erl1.c @@ -834,7 +834,7 @@ static int iscsit_attach_ooo_cmdsn( */ list_for_each_entry(ooo_tmp, &sess->sess_ooo_cmdsn_list, ooo_list) { - while (ooo_tmp->cmdsn < ooo_cmdsn->cmdsn) + if (ooo_tmp->cmdsn < ooo_cmdsn->cmdsn) continue; list_add(&ooo_cmdsn->ooo_list,