From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Vasquez <andrew.vasquez@qlogic.com>
Subject: Re: [PATCH] iommu: parse pci device scope even only intr remap is
 defined
Date: Thu, 11 Aug 2011 16:26:46 -0700
Message-ID: <20110811232646.GI76347@plapp.qlogic.org>
References: <CAE9FiQV0pnJW2BYdNSH3J-ZJ1JBtQ8qKf8HAfk1A98U3onn92A@mail.gmail.com>
 <20110721085636.GJ9216@elte.hu>
 <CAE9FiQU629jW2n8HTiA7ZZotfsUoXAkCvZ5XDOPeERubYemdzg@mail.gmail.com>
 <20110725071941.GA22518@elte.hu>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Return-path: <linux-pci-owner@vger.kernel.org>
Content-Disposition: inline
In-Reply-To: <20110725071941.GA22518@elte.hu>
Sender: linux-pci-owner@vger.kernel.org
To: Ingo Molnar <mingo@elte.hu>
Cc: Yinghai Lu <yinghai@kernel.org>, Suresh Siddha <suresh.b.siddha@intel.com>, Vinod Koul <vinod.koul@intel.com>, Dan Williams <dan.j.williams@intel.com>, Joerg Roedel <joerg.roedel@amd.com>, "H. Peter Anvin" <hpa@zytor.com>, linux scsi dev <linux-scsi@vger.kernel.org>, linux pci <linux-pci@vger.kernel.org>, "hpa@linux.intel.com" <hpa@linux.intel.com>, Avik Shau <avik.shau@qlogic.com>, Giridhar Malavali <giridhar.malavali@qlogic.com>
List-Id: linux-scsi@vger.kernel.org

On Mon, 25 Jul 2011, Ingo Molnar wrote:

> * Yinghai Lu <yinghai@kernel.org> wrote:
> 
> > > This looks very messy.
> > >
> > > CONFIG_DMAR has no clear meaning. The DMAR table parsing 
> > > functionality is intermixed with the DMAR feature itself. The 
> > > kernel code is littered with a couple of dozen CONFIG_DMAR 
> > > #ifdefs with no clear structure to the initialization and to the 
> > > separation of functionality.
> > 
> > CONFIG_DMAR is actually DMA_REMAP instead DMAR table.
> > 
> > or Do you prefer to clean them up further with following depency?
> > 
> > CONFIG_DMAR_TBL for DMAR table
> > CONFIG_DMA_REMAP for DMA remapping
> > CONFIG_INTR_REMAP for Interrupt remapping
> > and XXX_REMAP will select DMAR_TBL
> 
> 'DMAR', 'TBL' and 'INTR' are all misnomers!
> 
> 	CONFIG_DMA_REMAP_TABLE
> 	CONFIG_DMA_REMAP
> 	CONFIG_IRQ_REMAP
> 
> That way we'd get the 'DMAR tables' via CONFIG_DMA_REMAP_TABLE - on 
> top of which enabling CONFIG_DMA_REMAP and CONFIG_IRQ_REMAP would 
> enable and handle various hw remapping features.
> 
> (Does anyone else have better/other code structure suggestions?)
> 
> But yes, we should first do this rename/cleanup to clarify what it 
> all means, then fix whatever config-combos don't work perfectly yet.

All,

Is this re-work effort going to make it into 3.1?  With 3.1.0-rc1, we
are seeing the same 'no interupts being routed' issue.  Applying
Yinghai's patch to 3.1-rc1:

	http://www.spinics.net/lists/linux-scsi/msg53416.html

get's interrupts routing again....

Thanks, AV