From mboxrd@z Thu Jan 1 00:00:00 1970 From: scameron@beardog.cce.hp.com Subject: Re: [PATCH] scsi: Document generic scsi device attributes Date: Fri, 19 Aug 2011 10:41:35 -0500 Message-ID: <20110819154135.GF8422@beardog.cce.hp.com> References: <20110819144427.15191.54676.stgit@beardog.cce.hp.com> <4E4E7F8B.7020502@interlog.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from g6t0187.atlanta.hp.com ([15.193.32.64]:37968 "EHLO g6t0187.atlanta.hp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754825Ab1HSPli (ORCPT ); Fri, 19 Aug 2011 11:41:38 -0400 Content-Disposition: inline In-Reply-To: <4E4E7F8B.7020502@interlog.com> Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: Douglas Gilbert Cc: james.bottomley@hansenpartnership.com, stephenmcameron@gmail.com, akpm@linux-foundation.org, gregkh@suse.de, linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org On Fri, Aug 19, 2011 at 11:21:47AM -0400, Douglas Gilbert wrote: > On 11-08-19 10:44 AM, Stephen M. Cameron wrote: > >From: Stephen M. Cameron > > > > > > >+What: /sys/class/scsi_device/..../device/modalias > >+Date: April, 2007 > >+KernelVersion: Unknown > >+Contact: James Bottomley > >+Description: > >+ This read only string value contains a string of the form > >+ "scsi:t-0xXX" where "XX" are two hex digits representing the > >+ SCSI device type. See also the "type" attribute and table 47 > >+ in section 8.2.5.1 "Standard INQUIRY data" of the SCSI-2 > >+ specification. > > My copy of SCSI-2 is draft 10b from 1989 and it doesn't have a > section 8.2.5.1 . Since SCSI-2 was withdrawn over 10 years > ago perhaps you could use a more recent reference. [I see > webstore.ansi.org still sells the SCSI-2 standard for $30 .] > > SPC-3 is a standard [ANSI INCITS 408-2005; ISO/IEC 14776-453] > and the relevant section, judging from its last draft, would > be table 83 in section 6.4.2 . And it is now called the > "peripheral device type". I knew it was a mistake for me to try to figure out what the proper reference should be. If such things change, maybe having a reference in there at all is a mistake. Maybe it should just say something like, "the numbers correspond to the entries in the scsi_device_types[] array in drivers/scsi/scsi.c" since that file is more likely to be close at hand than whichever spec we might refer to. -- steve